Skip to content

Fixing Mesh version references in docs#3073

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
robscott:docs-version-fixes
May 13, 2024
Merged

Fixing Mesh version references in docs#3073
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
robscott:docs-version-fixes

Conversation

@robscott
Copy link
Copy Markdown
Member

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Follow up from #3066 (comment).

Does this PR introduce a user-facing change?:

NONE

/cc @howardjohn @keithmattix @kflynn

@k8s-ci-robot k8s-ci-robot requested a review from howardjohn May 10, 2024 23:07
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label May 10, 2024
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 10, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: keithmattix, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LiorLieberman
Copy link
Copy Markdown
Member

/lgtm
/hold in case you wanted someone else to review as well

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024
@kflynn
Copy link
Copy Markdown
Contributor

kflynn commented May 13, 2024

Thanks @robscott!

/lgtm

@kflynn
Copy link
Copy Markdown
Contributor

kflynn commented May 13, 2024

Let's see if I can do this... 🙂

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 67e304b into kubernetes-sigs:main May 13, 2024
BobyMCbobs pushed a commit to BobyMCbobs/kubernetes-sigs-gateway-api that referenced this pull request Jul 10, 2024
BobyMCbobs pushed a commit to BobyMCbobs/kubernetes-sigs-gateway-api that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants