-
Notifications
You must be signed in to change notification settings - Fork 620
chore: remove conformance/reports/latest link
#2389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove conformance/reports/latest link
#2389
Conversation
|
Hi @pmalek. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
So I was thinking about this, and all things considered: I don't think we actually need this symlink. It would be potentially a convenience if we were programmatically scanning the latest, but even then we could just use semver to figure that out. So rather than have to add a release step and all that, maybe we should just remove it entirely? |
902ee79 to
3f3b000
Compare
conformance/reports/latest link
👍 Removed |
mlavacca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pmalek!
/ok-to-test
/approve
shaneutt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlavacca, pmalek, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/area conformance
What this PR does / why we need it:
Removes the
conformance/reports/latest.Does this PR introduce a user-facing change?: