-
Notifications
You must be signed in to change notification settings - Fork 620
IPv6 conformance: Third time's the charm #2375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPv6 conformance: Third time's the charm #2375
Conversation
Signed-off-by: Keith Mattix II <[email protected]>
569c737 to
56c1b4d
Compare
Signed-off-by: Keith Mattix II <[email protected]>
Signed-off-by: Keith Mattix II <[email protected]>
Signed-off-by: Keith Mattix II <[email protected]>
Signed-off-by: Keith Mattix II <[email protected]>
And that's the expectation , how can you get a host:port without brackets? |
Indeed; our mesh conformance tests sometimes pass a raw podIP, so we need to change up the logic a bit |
|
got it, thanks for clarifying 😄 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, keithmattix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @keithmattix! This LGTM, but do you mind adding a release-note block? |
|
Ah thanks for the reminder @robscott. Just added one 👍🏾 |
|
/cherry-pick release-0.8 |
|
@robscott: once the present PR merges, I will cherry-pick it on top of release-0.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Keith Mattix II <[email protected]>
|
Thanks @keithmattix! /lgtm |
|
@robscott: new pull request created: #2381 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
net.SplitHostPorterrors if ipv6 addresses aren't in brackets; previous implementation fixed a different problem (SplitHostPort removes brackets if they are passed in)