Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion apis/v1beta1/shared_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ type ParentReference struct {
// Gateway has the AllowedRoutes field, and ReferenceGrant provides a
// generic way to enable any other kind of cross-namespace reference.
//
//<experimental:description>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nit, probably best to stick with the <gateway:experimental prefix we're using elsewhere.

Suggested change
//<experimental:description>
// <gateway:experimental:description>

// ParentRefs from a Route to a Service in the same namespace are "producer"
// routes, which apply default routing rules to inbound connections from
// any namespace to the Service.
Expand All @@ -75,6 +76,7 @@ type ParentReference struct {
// connections originating from the same namespace as the Route, for which
// the intended destination of the connections are a Service targeted as a
// ParentRef of the Route.
//</experimental:description>
//
// Support: Core
//
Expand Down Expand Up @@ -127,9 +129,11 @@ type ParentReference struct {
// and SectionName are specified, the name and port of the selected listener
// must match both specified values.
//
//<experimental:description>
// When the parent resource is a Service, this targets a specific port in the
// Service spec. When both Port (experimental) and SectionName are specified,
// the name and port of the selected port must match both specified values.
//</experimental:description>
//
// Implementations MAY choose to support other parent resources.
// Implementations supporting other types of parent resources MUST clearly
Expand Down Expand Up @@ -167,8 +171,9 @@ type CommonRouteSpec struct {
// There are two kinds of parent resources with "Core" support:
//
// * Gateway (Gateway conformance profile)
//<experimental:description>
// * Service (Mesh conformance profile, experimental, ClusterIP Services only)
//
//</experimental:description>
// This API may be extended in the future to support additional kinds of parent
// resources.
//
Expand All @@ -189,6 +194,7 @@ type CommonRouteSpec struct {
// Gateway has the AllowedRoutes field, and ReferenceGrant provides a
// generic way to enable other kinds of cross-namespace reference.
//
//<experimental:description>
// ParentRefs from a Route to a Service in the same namespace are "producer"
// routes, which apply default routing rules to inbound connections from
// any namespace to the Service.
Expand All @@ -198,6 +204,7 @@ type CommonRouteSpec struct {
// connections originating from the same namespace as the Route, for which
// the intended destination of the connections are a Service targeted as a
// ParentRef of the Route.
//</experimental:description>
//
// +optional
// +kubebuilder:validation:MaxItems=32
Expand Down
28 changes: 14 additions & 14 deletions config/crd/experimental/gateway.networking.k8s.io_grpcroutes.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading