enhancement: change default imagePullPolicy for gateway-api-admission-server to IfNotPresent

[networkhermit]

What type of PR is this?
/kind feature

What this PR does / why we need it:

gateway-api/config/webhook/admission_webhook.yaml

Lines 58 to 60 in 4597f0e

	- name: webhook
	image: registry.k8s.io/gateway-api/admission-server:v0.7.1
	imagePullPolicy: Always

Currently the default imagePullPolicy for webhook in standard-install.yaml is Always, which is not strictly needed as the image tag is semver (v0.7.1).

Change the imagePullPolicy to IfNotPresent helps air-gapped / restricted environment, and script in this repo are already use the kustomize hack to override the default.

As a side note, the build-install-yaml.sh release script is simply some file copying logic, it does not use kustomize or unsupported helm template.

Edited:

Two Jobs in standard-install.yaml already uses IfNotPresent, so it also makes sense to keep it consistent.

Which issue(s) this PR fixes:

Fixes #2214

Does this PR introduce a user-facing change?:

Changed default imagePullPolicy for gateway-api-admission-server to IfNotPresent.

[k8s-ci-robot]

Welcome @networkhermit!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @networkhermit. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[shaneutt]

To me this makes perfect sense as Always can be wasteful in some situations, but disruptive or breaking in others (e.g. network restricted environments as the author had alluded to).

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: networkhermit, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [shaneutt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment