The `AttachedRoutes` field does not reflect the expected route status

[mlavacca]

Problem statement

The Gateway AttachedRoutes field states:

gateway-api/apis/v1beta1/gateway_types.go

Lines 677 to 679 in 26ce3a3

	// AttachedRoutes represents the total number of Routes that have been
	// successfully attached to this Listener.
	AttachedRoutes int32 `json:"attachedRoutes"`

But the *Route Attached condition does not exist (the Detached condition with reason Attached was used in the past, and it is now deprecated). The Accepted condition is meant to be used that a route can be considered accepted by (attached to) a Gateway.

Proposed solution

We could rename the AttachedRoutes field of the Gateway status to AcceptedRoutes to reflect the route status condition to check in order to increment (or decrement) the number of routes considered accepted.

[robscott]

Unfortunately renaming a field would require a new API version and likely also a conversion webhook, both things we're trying to avoid. I think the concept of "AttachedRoutes" still makes sense, we probably just want to update the spec to say that it represents the "number of Accepted Routes that are attached to this Listener".

[shaneutt]

Because changing the API would be such a massive undertaking at this point let's go with Rob's suggestion and improve the documentation:

/triage accepted

We should probably do this prior to GA to help avoid confusion sooner rather than later:

/priority important-longterm
/milestone v1.0.0
/help

[k8s-ci-robot]

@shaneutt:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Because changing the API would be such a massive undertaking at this point let's go with Rob's suggestion and improve the documentation:

/triage accepted

We should probably do this prior to GA to help avoid confusion sooner rather than later:

/priority important-longterm
/milestone v1.0.0
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.