-
Notifications
You must be signed in to change notification settings - Fork 206
docs: added examples to address various generative AI application scenarios by using gateway api inference extension #812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added examples to address various generative AI application scenarios by using gateway api inference extension #812
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @capri-xiyue. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Xiyue Yu <[email protected]>
|
/assign @kfswain |
|
/assign @robscott |
|
/ok-to-test |
kfswain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments, and then I have one larger one. How do you find this page naturally on our site?
I used simple URL manipulation to display the page on this PR's staging preview: https://deploy-preview-812--gateway-api-inference-extension.netlify.app/guides/use-cases/
But otherwise, I think this page (which is a great addition) would go unseen by most users since I don't think there is a link to it anywhere.
|
Can you convert the diagrams to SVG format? |
Just a thought when I've tried this: SVG's can be dark-mode unfriendly if you are using lot's of darks (which is highly likely if the drawing tool used is light-mode based) |
Consider adding the doc to |
|
Thanks @capri-xiyue! Deploy preview is here: https://deploy-preview-812--gateway-api-inference-extension.netlify.app/guides/use-cases/ Need to add this page to mkdocs.yml to have it show up in navigation. Since this new page actually has 2 distinct examples, I'd recommend splitting this into separate guides/pages for each.
Since this looks like it's coming from Slides, it can be a huge pain to get a similar looking SVG. What we've done is to make the original source doc publicly accessible and left a comment linking to it by any uses of the image, ie https://github.com/kubernetes-sigs/gateway-api/blob/main/site-src/index.md?plain=1#L12. |
I will add it to |
done |
Co-authored-by: Cong Liu <[email protected]>
liu-cong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to me. Pls address the nits and will let others to approve
Co-authored-by: Cong Liu <[email protected]>
Co-authored-by: Rob Scott <[email protected]>
robscott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @capri-xiyue!
Co-authored-by: Rob Scott <[email protected]>
Co-authored-by: Rob Scott <[email protected]>
|
/approve Thanks @capri-xiyue ! So sorry for the delay! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: capri-xiyue, kfswain, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
…narios by using gateway api inference extension (kubernetes-sigs#812) * added common cases * added more details Signed-off-by: Xiyue Yu <[email protected]> * fixed comments * changed file location * fixed typo * Update site-src/guides/serve-multiple-lora-adapters.md Co-authored-by: Cong Liu <[email protected]> * Update site-src/guides/serve-multiple-lora-adapters.md Co-authored-by: Cong Liu <[email protected]> * Update mkdocs.yml Co-authored-by: Rob Scott <[email protected]> * Update site-src/guides/serve-multiple-lora-adapters.md Co-authored-by: Rob Scott <[email protected]> * Update site-src/guides/serve-multiple-genai-models.md Co-authored-by: Rob Scott <[email protected]> * added subsession * fixed wording --------- Signed-off-by: Xiyue Yu <[email protected]> Co-authored-by: Cong Liu <[email protected]> Co-authored-by: Rob Scott <[email protected]>
Added examples to address various generative AI application scenarios by using gateway api inference extension