Skip to content

Conversation

@capri-xiyue
Copy link
Contributor

Added examples to address various generative AI application scenarios by using gateway api inference extension

@netlify
Copy link

netlify bot commented May 9, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 6fa496f
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6827bdefc8a4e60008fd1a2c
😎 Deploy Preview https://deploy-preview-812--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 9, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and liu-cong May 9, 2025 16:55
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 9, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @capri-xiyue. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 9, 2025
Signed-off-by: Xiyue Yu <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 9, 2025
@capri-xiyue
Copy link
Contributor Author

/assign @kfswain

@capri-xiyue
Copy link
Contributor Author

/assign @robscott

@kfswain
Copy link
Collaborator

kfswain commented May 13, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2025
Copy link
Collaborator

@kfswain kfswain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, and then I have one larger one. How do you find this page naturally on our site?

I used simple URL manipulation to display the page on this PR's staging preview: https://deploy-preview-812--gateway-api-inference-extension.netlify.app/guides/use-cases/

But otherwise, I think this page (which is a great addition) would go unseen by most users since I don't think there is a link to it anywhere.

@danehans
Copy link
Contributor

Can you convert the diagrams to SVG format?

@kfswain
Copy link
Collaborator

kfswain commented May 14, 2025

Can you convert the diagrams to SVG format?

Just a thought when I've tried this: SVG's can be dark-mode unfriendly if you are using lot's of darks (which is highly likely if the drawing tool used is light-mode based)

@danehans
Copy link
Contributor

Some small comments, and then I have one larger one. How do you find this page naturally on our site?

Consider adding the doc to site-src/guides/.

@robscott
Copy link
Member

Thanks @capri-xiyue!

Deploy preview is here: https://deploy-preview-812--gateway-api-inference-extension.netlify.app/guides/use-cases/

Need to add this page to mkdocs.yml to have it show up in navigation. Since this new page actually has 2 distinct examples, I'd recommend splitting this into separate guides/pages for each.

Can you convert the diagrams to SVG format?

Since this looks like it's coming from Slides, it can be a huge pain to get a similar looking SVG. What we've done is to make the original source doc publicly accessible and left a comment linking to it by any uses of the image, ie https://github.com/kubernetes-sigs/gateway-api/blob/main/site-src/index.md?plain=1#L12.

@capri-xiyue
Copy link
Contributor Author

Some small comments, and then I have one larger one. How do you find this page naturally on our site?

I used simple URL manipulation to display the page on this PR's staging preview: https://deploy-preview-812--gateway-api-inference-extension.netlify.app/guides/use-cases/

But otherwise, I think this page (which is a great addition) would go unseen by most users since I don't think there is a link to it anywhere.

I will add it to mkdocs.yml to have it show up in navigation.

@capri-xiyue
Copy link
Contributor Author

Thanks @capri-xiyue!

Deploy preview is here: https://deploy-preview-812--gateway-api-inference-extension.netlify.app/guides/use-cases/

Need to add this page to mkdocs.yml to have it show up in navigation. Since this new page actually has 2 distinct examples, I'd recommend splitting this into separate guides/pages for each.

Can you convert the diagrams to SVG format?

Since this looks like it's coming from Slides, it can be a huge pain to get a similar looking SVG. What we've done is to make the original source doc publicly accessible and left a comment linking to it by any uses of the image, ie https://github.com/kubernetes-sigs/gateway-api/blob/main/site-src/index.md?plain=1#L12.

done

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2025
@capri-xiyue capri-xiyue requested a review from liu-cong May 16, 2025 21:17
Copy link
Contributor

@liu-cong liu-cong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me. Pls address the nits and will let others to approve

Co-authored-by: Rob Scott <[email protected]>
@capri-xiyue capri-xiyue requested a review from robscott May 16, 2025 22:14
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @capri-xiyue!

@kfswain
Copy link
Collaborator

kfswain commented May 22, 2025

/approve

Thanks @capri-xiyue ! So sorry for the delay!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue, kfswain, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2025
@kfswain
Copy link
Collaborator

kfswain commented May 22, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit ed32a43 into kubernetes-sigs:main May 22, 2025
8 checks passed
rlakhtakia pushed a commit to rlakhtakia/gateway-api-inference-extension that referenced this pull request Jun 11, 2025
…narios by using gateway api inference extension (kubernetes-sigs#812)

* added common cases

* added more details

Signed-off-by: Xiyue Yu <[email protected]>

* fixed comments

* changed file location

* fixed typo

* Update site-src/guides/serve-multiple-lora-adapters.md

Co-authored-by: Cong Liu <[email protected]>

* Update site-src/guides/serve-multiple-lora-adapters.md

Co-authored-by: Cong Liu <[email protected]>

* Update mkdocs.yml

Co-authored-by: Rob Scott <[email protected]>

* Update site-src/guides/serve-multiple-lora-adapters.md

Co-authored-by: Rob Scott <[email protected]>

* Update site-src/guides/serve-multiple-genai-models.md

Co-authored-by: Rob Scott <[email protected]>

* added subsession

* fixed wording

---------

Signed-off-by: Xiyue Yu <[email protected]>
Co-authored-by: Cong Liu <[email protected]>
Co-authored-by: Rob Scott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants