Fix approx prefix cache dataproducer auto-initialization#2798
Merged
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
cncf-cla: yes
Contributor
Author
|
/assign @ahg-g |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, rahulgurnani The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
rahulgurnani
force-pushed
the
datalayer-bugfix
branch
from
April 7, 2026 04:54
250cb28 to
7f23117
Compare
rahulgurnani
force-pushed
the
datalayer-bugfix
branch
from
April 7, 2026 04:56
7f23117 to
921391a
Compare
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Closed
elevran
pushed a commit
to llm-d/llm-d-router
that referenced
this pull request
Apr 23, 2026
…sigs/gateway-api-inference-extension#2798) * Fix bug with initialization of the approx prefix cache dataproducer * Also add params
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialize the approx prefix cache dataproducer even when parameters are nil (which can happen often)
What type of PR is this?
/kind bug
What this PR does / why we need it:
During addressing last few comments in the earlier PR, this bug was introduced.
Identified while running the final benchmark but by then #2453 was submitted so sent a separate fix.
Benchmark numbers on this change:
The TTFT numbers are in the similar ball park as #2453
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: