fix(bbr): enable response header/body processing in Istio EnvoyFilter#2557
Conversation
Signed-off-by: Abdallah Samara <abdallahsamabd@gmail.com>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @abdallahsamabd. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abdallahsamabd, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…kubernetes-sigs#2557) Signed-off-by: Abdallah Samara <abdallahsamabd@gmail.com>
…kubernetes-sigs/gateway-api-inference-extension#2557) Signed-off-by: Abdallah Samara <abdallahsamabd@gmail.com>
What type of PR is this?
/kind bug
What this PR does / why we need it:
The Istio EnvoyFilter configuration for BBR had
response_header_mode: "SKIP"andresponse_body_mode: "NONE", which meant Envoy never forwarded response headers or body to the BBR ext_proc server. This prevented response plugins (added in #2369, #2477) from being invoked at all.This PR updates the processing mode to:
response_header_mode: "SEND"response_body_mode: "FULL_DUPLEX_STREAMED"Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: