small refactor of pluggable bbr interfaces by nirrozenbaum · Pull Request #2513 · kubernetes-sigs/gateway-api-inference-extension

nirrozenbaum · 2026-03-07T14:35:46Z

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
small refactor of pluggable bbr plugins framework.
add request/response types and updated interfaces to make it possible for a single plugin to have both request/response hooks.
pay attention that pluggable bbr is still not wired.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

None

netlify · 2026-03-07T14:35:54Z

✅ Deploy Preview for gateway-api-inference-extension ready!

Name	Link
🔨 Latest commit	`b073e74`
🔍 Latest deploy log	https://app.netlify.com/projects/gateway-api-inference-extension/deploys/69ad781cdb4fd70008ddc8b5
😎 Deploy Preview	https://deploy-preview-2513--gateway-api-inference-extension.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

k8s-ci-robot · 2026-03-07T14:35:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [nirrozenbaum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nirrozenbaum · 2026-03-07T14:36:13Z

/cc @elevran @shmuelk

nirrozenbaum · 2026-03-07T23:32:57Z

/hold

I'm iterating on this a bit more to make it cleaner with the other parts of the code.

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

elevran · 2026-03-08T09:04:43Z

 		before := time.Now()
-		updatedHeaders, updatedBody, err = plugin.Execute(ctx, updatedHeaders, updatedBody)
-		metrics.RecordPluginProcessingLatency(executeExtensionPoint, plugin.TypedName().Type, plugin.TypedName().Name, time.Since(before))
+		mutatedRequest, err = plugin.ProcessRequest(ctx, request)


when executing a chain, does the N+1 plugin see mutations done by Plugin N? Should it? If not, how do you "merge" mutations from different plugins?

yes. plugin N+1 should see mutations of plugin N.
the order of execution is defined by whoever configures bbr. then plugins are running sequentially and may override the previous plugins.
latest update holds.

elevran · 2026-03-08T09:05:59Z

+	for _, plugin := range s.responsePlugins {
+		log.FromContext(ctx).V(logutil.VERBOSE).Info("Executing response plugin", "plugin", plugin.TypedName())
+		before := time.Now()
+		mutatedResponse, err = plugin.ProcessResponse(ctx, response)


Same question regarding processing of mutations in a chain.

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

nirrozenbaum · 2026-03-08T11:02:58Z

PR is ready for another review iteration.
/unhold

elevran · 2026-03-08T10:26:31Z

-	// Payload processor can mutate the headers and/or the body of the message.
-	Execute(ctx context.Context, headers map[string]string, body map[string]any) (updatedHeaders map[string]string, updatedBody map[string]any, err error)
+	// ProcessRequest runs the RequestProcessor plugin.
+	// RequestProcessor can mutate the headers and/or the body of the request.


clarify what an error return means (abort chained processing, return error to Envoy to abort transaction, ignore this plugin, ...)

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

nirrozenbaum · 2026-03-08T13:07:39Z

+func (r *InferenceMessage) RemoveHeader(key string) {
+	if _, ok := r.Headers[key]; ok {
+		delete(r.Headers, key)
+		delete(r.mutatedHeaders, key) // avoid sending set and remove for same key
+		r.removedHeaders.Insert(key)
+	}
+}


@elevran eventually I've added also the removed headers cause that was a very simple change.
(less than 20 LoC).

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

elevran

/lgtm

* small refactor of pluggable bbr interfaces Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * minor update Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * godoc Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * typo Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * iterate on interfaces Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * more updates Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * code review Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * typo Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * minor change towards adding deleted headers Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * make linter happy Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * linter and tests Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * embed InferenceMessage in request/response Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * add support for removing headers Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * minor tweak Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> --------- Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> Signed-off-by: Abdallah Samara <abdallahsamabd@gmail.com>

* small refactor of pluggable bbr interfaces Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * minor update Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * godoc Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * typo Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * iterate on interfaces Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * more updates Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * code review Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * typo Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * minor change towards adding deleted headers Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * make linter happy Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * linter and tests Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * embed InferenceMessage in request/response Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * add support for removing headers Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * minor tweak Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> --------- Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

…pi-inference-extension#2513) * small refactor of pluggable bbr interfaces Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * minor update Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * godoc Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * typo Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * iterate on interfaces Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * more updates Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * code review Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * typo Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * minor change towards adding deleted headers Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * make linter happy Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * linter and tests Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * embed InferenceMessage in request/response Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * add support for removing headers Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * minor tweak Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> --------- Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 7, 2026

k8s-ci-robot requested review from kfswain and robscott March 7, 2026 14:35

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 7, 2026

k8s-ci-robot requested review from elevran and shmuelk March 7, 2026 14:36

hexfusion reviewed Mar 7, 2026

View reviewed changes

Comment thread pkg/bbr/framework/plugins.go Outdated

Comment thread pkg/bbr/framework/plugins.go Outdated

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2026

nirrozenbaum added 5 commits March 8, 2026 09:15

small refactor of pluggable bbr interfaces

1aa9127

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

minor update

bd753b6

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

godoc

13327ad

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

typo

4e044f5

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

iterate on interfaces

329209f

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

elevran reviewed Mar 8, 2026

View reviewed changes

more updates

5a6e886

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

nirrozenbaum force-pushed the bbr-plugins-refactor branch from f38b742 to 5a6e886 Compare March 8, 2026 09:32

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 8, 2026

nirrozenbaum added 3 commits March 8, 2026 11:38

code review

3b8a125

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

typo

881b3f2

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

minor change towards adding deleted headers

38411d9

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

nirrozenbaum requested a review from elevran March 8, 2026 09:58

nirrozenbaum added 2 commits March 8, 2026 12:23

make linter happy

ad53256

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

linter and tests

de8e122

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2026

elevran reviewed Mar 8, 2026

View reviewed changes

nirrozenbaum requested a review from elevran March 8, 2026 11:17

nirrozenbaum added 2 commits March 8, 2026 13:36

embed InferenceMessage in request/response

41551e5

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

add support for removing headers

ac01e51

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

nirrozenbaum commented Mar 8, 2026

View reviewed changes

minor tweak

b073e74

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

elevran reviewed Mar 8, 2026

View reviewed changes

k8s-ci-robot assigned elevran Mar 8, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2026

k8s-ci-robot merged commit 2faa44c into kubernetes-sigs:main Mar 8, 2026
11 checks passed

nirrozenbaum deleted the bbr-plugins-refactor branch March 8, 2026 21:18

nirrozenbaum mentioned this pull request Mar 9, 2026

[pluggable bbr] add tests for testing request headers setting/remove by multiple different plugins #2526

Closed

nirrozenbaum added this to the Pluggable BBR milestone Mar 10, 2026

Conversation

nirrozenbaum commented Mar 7, 2026

Uh oh!

netlify Bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for gateway-api-inference-extension ready!

Uh oh!

k8s-ci-robot commented Mar 7, 2026

Uh oh!

nirrozenbaum commented Mar 7, 2026

Uh oh!

Uh oh!

Uh oh!

nirrozenbaum commented Mar 7, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elevran Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

nirrozenbaum Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

elevran Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

nirrozenbaum commented Mar 8, 2026

Uh oh!

elevran Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nirrozenbaum Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

elevran left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

netlify Bot commented Mar 7, 2026 •

edited

Loading