docs: switch quickstarts to agentgateway#2505
Conversation
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
k8s-ci-robot
added
the
kind/documentation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
| --8<-- "site-src/_includes/model-server-gpu.md" | ||
|
|
||
| ```bash | ||
| export INFERENCE_POOL_NAME=${MODEL_SERVER}-qwen3-32b |
There was a problem hiding this comment.
why do we repeat the vars from L23-24 on every tab?
There was a problem hiding this comment.
Removed the shared INFERENCE_POOL_NAME and MODEL_NAME definitions from the preamble. Keeping those values owned by each tab makes the selected flow self-contained, and it matches the structure in index.md where GPU, CPU, and simulator each define their own values.
There was a problem hiding this comment.
@nirrozenbaum thanks for the review! The current latest guide duplicates those vars. IMHO quickstart tabs should be self-contained for copy/paste. I'll remove the common definitions rather than make the tabs depend on hidden state.
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* docs: fix quickstart simulator flow Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> * docs: switch quickstarts to agentgateway Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> * docs: drop duplicate quickstart label var Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> * docs: remove duplicated quickstart vars Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> --------- Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
* docs: fix quickstart simulator flow Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> * docs: switch quickstarts to agentgateway Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> * docs: drop duplicate quickstart label var Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> * docs: remove duplicated quickstart vars Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> --------- Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
3 participants
What type of PR is this?
/kind documentation
What this PR does / why we need it:
v1.0.0-alpha.4v1.4.0-rc.1artifactsWhich issue(s) this PR fixes:
None
Does this PR introduce a user-facing change?: