Skip to content

remove redundant field body and isStreaming in requestcontrol.Response#2474

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
zetxqx:removebody
Mar 4, 2026
Merged

remove redundant field body and isStreaming in requestcontrol.Response#2474
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
zetxqx:removebody

Conversation

@zetxqx
Copy link
Copy Markdown
Contributor

@zetxqx zetxqx commented Mar 4, 2026

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Currently body and isStreaming is not assigned/referenced in other places.
Remove them for now, we can always add it back when we need them when doing #2471

Which issue(s) this PR fixes:

Fixes #2472

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 4, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 4, 2026

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 333dd29
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/69a790ab4ee01c0008c2a671
😎 Deploy Preview https://deploy-preview-2474--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 4, 2026
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 4, 2026
@zetxqx
Copy link
Copy Markdown
Contributor Author

zetxqx commented Mar 4, 2026

/assign @kfswain @ahg-g

Please take a look, I also removed the isStreaming field as it's not assigned/referenced now.

@zetxqx zetxqx changed the title remove redundant field body and isStreaming in fwk.Response remove redundant field body and isStreaming in requestcontrol.Response Mar 4, 2026
@ahg-g
Copy link
Copy Markdown
Contributor

ahg-g commented Mar 4, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, zetxqx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2026
@k8s-ci-robot k8s-ci-robot merged commit 5f9b768 into kubernetes-sigs:main Mar 4, 2026
13 checks passed
RyanRosario pushed a commit to RyanRosario/gateway-api-inference-extension that referenced this pull request Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the body parameter from the request control Response type

3 participants