Skip to content

datastore minor cleanup#2448

Merged
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
nirrozenbaum:ds-cleanup
Mar 14, 2026
Merged

datastore minor cleanup#2448
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
nirrozenbaum:ds-cleanup

Conversation

@nirrozenbaum
Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
minor cleanup for datastore.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

None

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 2, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 2, 2026
@k8s-ci-robot k8s-ci-robot requested review from danehans and elevran March 2, 2026 12:28
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 2, 2026

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 2961793
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/69a59a27fb2784000830de46
😎 Deploy Preview https://deploy-preview-2448--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 2, 2026
@nirrozenbaum
Copy link
Copy Markdown
Contributor Author

cc: @delavet made few tweaks in ds. no behavior change.

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>
@elevran
Copy link
Copy Markdown
Contributor

elevran commented Mar 2, 2026

I'm not familar with the "active ports annotation". How related to the inference pool ports? Can different pods have different ports?

@nirrozenbaum
Copy link
Copy Markdown
Contributor Author

nirrozenbaum commented Mar 2, 2026

I'm not familar with the "active ports annotation". How related to the inference pool ports? Can different pods have different ports?

@elevran yup. this is a new PR that was merged earlier today.
the pool ports define the valid ports. the annotation can mark a subset of these ports as the only active ports.
so if the pool has ports 8000-8007, the annotation can declare ports from this range (e.g., 8000, 8003, then only these two are active).

if no annotation is declared on the pod, all pool ports are used.

more information on the use case in #2256.

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>
@ahg-g
Copy link
Copy Markdown
Contributor

ahg-g commented Mar 14, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2026
@k8s-ci-robot k8s-ci-robot merged commit 874aae8 into kubernetes-sigs:main Mar 14, 2026
11 checks passed
@nirrozenbaum nirrozenbaum deleted the ds-cleanup branch March 14, 2026 15:59
BizerNotNull pushed a commit to BizerNotNull/gateway-api-inference-extension that referenced this pull request Mar 15, 2026
* datastore minor cleanup

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

* minor update

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

* remove extra space

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

---------

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>
elevran pushed a commit to llm-d/llm-d-inference-scheduler that referenced this pull request Apr 23, 2026
…ion#2448)

* datastore minor cleanup

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

* minor update

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

* remove extra space

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>

---------

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants