datastore minor cleanup#2448
Conversation
Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
cc: @delavet made few tweaks in ds. no behavior change. |
Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>
|
I'm not familar with the "active ports annotation". How related to the inference pool ports? Can different pods have different ports? |
@elevran yup. this is a new PR that was merged earlier today. if no annotation is declared on the pod, all pool ports are used. more information on the use case in #2256. |
Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>
|
/lgtm |
* datastore minor cleanup Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * minor update Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * remove extra space Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> --------- Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>
…ion#2448) * datastore minor cleanup Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * minor update Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> * remove extra space Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com> --------- Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
minor cleanup for datastore.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: