Second part of refactoring of the Ext Proc code between the EPP and the BBR#2446
Merged
k8s-ci-robot merged 4 commits intokubernetes-sigs:mainfrom Mar 8, 2026
Merged
Conversation
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/L
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
needs-rebase
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
shmuelk
force-pushed
the
ext-proc-refactor-2
branch
from
a29f8af to
2c6cb1b
Compare
k8s-ci-robot
removed
the
needs-rebase
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum, shmuelk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
RyanRosario
pushed a commit
to RyanRosario/gateway-api-inference-extension
that referenced
this pull request
Mar 9, 2026
…he BBR (kubernetes-sigs#2446) * Moved error utilities to pkg/common Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Updates due to move of error utilities Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Test updates due to move of error utilities Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Fixed test Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> --------- Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
BizerNotNull
pushed a commit
to BizerNotNull/gateway-api-inference-extension
that referenced
this pull request
Mar 15, 2026
…he BBR (kubernetes-sigs#2446) * Moved error utilities to pkg/common Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Updates due to move of error utilities Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Test updates due to move of error utilities Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Fixed test Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> --------- Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
elevran
pushed a commit
to llm-d/llm-d-inference-scheduler
that referenced
this pull request
Apr 23, 2026
…he BBR (kubernetes-sigs/gateway-api-inference-extension#2446) * Moved error utilities to pkg/common Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Updates due to move of error utilities Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Test updates due to move of error utilities Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Fixed test Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> --------- Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
nirrozenbaum
pushed a commit
to llm-d/llm-d-inference-payload-processor
that referenced
this pull request
Apr 28, 2026
…he BBR (kubernetes-sigs/gateway-api-inference-extension#2446) * Moved error utilities to pkg/common Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Updates due to move of error utilities Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Test updates due to move of error utilities Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Fixed test Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> --------- Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
elevran
pushed a commit
to llm-d/llm-d-inference-scheduler
that referenced
this pull request
May 3, 2026
…he BBR (kubernetes-sigs/gateway-api-inference-extension#2446) * Moved error utilities to pkg/common Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Updates due to move of error utilities Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Test updates due to move of error utilities Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Fixed test Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> --------- Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Both the Endpoint Picker (EPP) and the Body Based Router (BBR) are Envoy ExtProc filters. There is much code that has been copy and pasted from one to the other.
This PR is the second in a series of PRs that will refactor out the common Ext Proc processing code into a set of reusable packages. This is being done to try and keep the PRs somewhat smaller.
In particular this PR:
1. Moves the error utility code to a common package
2. Changed the InferencePoolResourceExausted error code to ResourceExausted, to be more generic.
3. Updates other parts of the code base due to the above changes
Which issue(s) this PR fixes:
Ref: #2427
Does this PR introduce a user-facing change?: