Support arm64 builds#2350
Conversation
|
Welcome @ed-pai! |
|
Hi @ed-pai. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Bump on this. --build-arg would be implicit in most cases or builder dependent, but GOARCH would remain. This would be a great change. |
9cc4204 to
836ed1d
Compare
|
Thanks for the changes /lgtm |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ed-pai, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This reverts commit 9a03451.
* Support arm64 builds * Add some redundant TARGETARCH, just in case
What type of PR is this?
/kind feature
What this PR does / why we need it:
Updates build scripts for multi-arch support (arm64 & amd64). This enables support for Nvidia GH200/GH200/DGX-Spark system. The change leverages Go's built-in cross compiling to handle arm64 binary and image creation on the GCP servers. Validated cross compiling works to build amd64 from an arm64 system with
make image-build PLATFORMS=linux/amd64 IMAGE_TAG=epp:test-amd64-latest. Validated image runs on GH200 system.Which issue(s) this PR fixes:
Fixes #685
Does this PR introduce a user-facing change?: