Skip to content

[release-1.3] Increase default FlowGCTimeout to 1h to prevent premature GC#2154

Merged
kfswain merged 1 commit intokubernetes-sigs:release-1.3from
k8s-infra-cherrypick-robot:cherry-pick-2143-to-release-1.3
Jan 20, 2026
Merged

[release-1.3] Increase default FlowGCTimeout to 1h to prevent premature GC#2154
kfswain merged 1 commit intokubernetes-sigs:release-1.3from
k8s-infra-cherrypick-robot:cherry-pick-2143-to-release-1.3

Conversation

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #2143

/assign kfswain

Increased the default Flow Control garbage collection timeout to 1 hour. This prevents the accidental deletion of active flows during long queueing periods, improving stability during scale-from-zero.

This commit increases the default Flow Garbage Collection timeout from
from 5 minutes to 1 hour.

This serves as a mitigation for a race condition where requests pending
in the queue for longer than the GC timeout (e.g., during
scale-from-zero) could result in the underlying flow state being deleted
while the request was still active.
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 14, 2026
@kfswain
Copy link
Copy Markdown
Collaborator

kfswain commented Jan 20, 2026

Forcing the merge as we have removed the failing check in: #2105

The k8s org doesnt allow permissions to GHA as per this doc also did my own investigation and asked in gh-management slack

@kfswain
Copy link
Copy Markdown
Collaborator

kfswain commented Jan 20, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2026
@kfswain kfswain merged commit 60e1f2e into kubernetes-sigs:release-1.3 Jan 20, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants