changed httproute creation to be behind a flag.#2118
changed httproute creation to be behind a flag.#2118k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
in the long term this should be moved to a separate chart. Signed-off-by: Nir Rozenbaum <[email protected]>
k8s-ci-robot
added
the
kind/cleanup
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
| helm install vllm-llama3-8b-instruct \ | ||
| --set inferencePool.modelServers.matchLabels.app=vllm-llama3-8b-instruct \ | ||
| --set provider.name=$GATEWAY_PROVIDER \ | ||
| --set experimentalGateway.enabled=true \ |
There was a problem hiding this comment.
Shouldn't you be setting experimentalGateway.name and experimentalGateway.baseModel as well?
There was a problem hiding this comment.
name defaults to inference-gateway which is what we use in the quickstart.
baseModel should be used only in bbr guide (which will be updated after this PR as followup), when doing helm upgrade.
for a single epp, baseModel is not used.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/cherrypick release-1.3 |
|
@ahg-g: new pull request created: #2129 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
in the long term this should be moved to a separate chart.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
a fix to #2054 (comment)
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
/cc @ahg-g @kfswain