Skip to content

added optional base model flag to inferencepool helm chart#2073

Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
nirrozenbaum:helm-infpool
Jan 6, 2026
Merged

added optional base model flag to inferencepool helm chart#2073
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
nirrozenbaum:helm-infpool

Conversation

@nirrozenbaum
Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
adding optional base model flag to the inferencepool helm chart. if the flag is set, the HttpRoute will be set to match the pool only when the header X-Gateway-Base-Model-Name is set to the given base model. this is needed for #1812.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

None

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 6, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 6, 2026

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 18f1e81
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/695d028faeef37000899d270
😎 Deploy Preview https://deploy-preview-2073--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 6, 2026
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
@shmuelk
Copy link
Copy Markdown
Contributor

shmuelk commented Jan 6, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2026
@k8s-ci-robot k8s-ci-robot merged commit d92afe1 into kubernetes-sigs:main Jan 6, 2026
12 checks passed
@nirrozenbaum nirrozenbaum deleted the helm-infpool branch January 6, 2026 13:04
davidbreitgand pushed a commit to davidbreitgand/gateway-api-inference-extension that referenced this pull request Jan 6, 2026
…s-sigs#2073)

* added optional base model flag to inferencepool helm chart

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

* typo

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

---------

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants