Skip to content

test: refactor Kustomize utils to support delete operations#2033

Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
AvineshTripathi:feat/delete-crds
Apr 1, 2026
Merged

test: refactor Kustomize utils to support delete operations#2033
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
AvineshTripathi:feat/delete-crds

Conversation

@AvineshTripathi
Copy link
Copy Markdown
Contributor

@AvineshTripathi AvineshTripathi commented Dec 22, 2025

Previously, setupInfra used kustomize to create CRDs from config/crd/, but the cleanup logic only deleted specific CRDs. This left dangling CRDs in the cluster, making it difficult to re-run tests.

Refactor CreateCrdsFromKustomize to accept an action callback and introduce DeleteAndVerifyObjs. This enables using the same Kustomize configuration to properly identify and delete all created CRDs during cleanup.

/kind test

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 22, 2025

@AvineshTripathi: The label(s) kind/test cannot be applied, because the repository doesn't have them.

Details

In response to this:

Previously, setupInfra used kustomize to create CRDs from config/crd/, but the cleanup logic only deleted specific CRDs. This left dangling CRDs in the cluster, making it difficult to re-run tests.

Refactor CreateCrdsFromKustomize to accept an action callback and introduce DeleteAndVerifyObjs. This enables using the same Kustomize configuration to properly identify and delete all created CRDs during cleanup.

/kind test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 22, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 393d5c9
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/69cb5cf5726eac00080c477a
😎 Deploy Preview https://deploy-preview-2033--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 22, 2025

Hi @AvineshTripathi. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 22, 2025
@AvineshTripathi
Copy link
Copy Markdown
Contributor Author

AvineshTripathi commented Jan 18, 2026

hey @danehans can you have a look at this PR please

@AvineshTripathi AvineshTripathi mentioned this pull request Feb 18, 2026
Closed
11 tasks
@ahg-g
Copy link
Copy Markdown
Contributor

ahg-g commented Mar 14, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 14, 2026
@ahg-g
Copy link
Copy Markdown
Contributor

ahg-g commented Mar 14, 2026

@AvineshTripathi sorry for the latest response, are you able to resolve the conflicts?

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2026
@AvineshTripathi
Copy link
Copy Markdown
Contributor Author

AvineshTripathi commented Mar 14, 2026 •
edited
Loading

hey @ahg-g, I fixed the conflicts, PTAL!

Updates: looking into why the test failed.

@AvineshTripathi
Copy link
Copy Markdown
Contributor Author

AvineshTripathi commented Mar 14, 2026

/retest

@kfswain kfswain added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 26, 2026
@kfswain
Copy link
Copy Markdown
Collaborator

kfswain commented Mar 26, 2026 •
edited
Loading

/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 26, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AvineshTripathi, kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2026
@kfswain kfswain removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2026
@kfswain
Copy link
Copy Markdown
Collaborator

kfswain commented Mar 26, 2026

Hey @AvineshTripathi looks like we have some formatting issues, can we get this PR cleaned up and passing CI?

@AvineshTripathi
test: refactor Kustomize utils to support delete operations
ab7df57 
Added DeleteAndVerifyObjs and updated CreateCrdsFromKustomize to accept an action callback, enabling reuse for both creation and deletion workflows. Also exported CreateAndVerifyObjs for broader usage.

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>
@AvineshTripathi
fix: lint error
393d5c9
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2026
@AvineshTripathi
Copy link
Copy Markdown
Contributor Author

AvineshTripathi commented Mar 31, 2026

hey @kfswain the issue is fixed. PTAL

@ahg-g
Copy link
Copy Markdown
Contributor

ahg-g commented Apr 1, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2026
@k8s-ci-robot k8s-ci-robot merged commit 9400b8e into kubernetes-sigs:main Apr 1, 2026
11 checks passed
elevran pushed a commit to llm-d/llm-d-inference-scheduler that referenced this pull request Apr 23, 2026
@AvineshTripathi
test: refactor Kustomize utils to support delete operations (kubernet…
f8a415b 
…es-sigs/gateway-api-inference-extension#2033)

* test: refactor Kustomize utils to support delete operations

Added DeleteAndVerifyObjs and updated CreateCrdsFromKustomize to accept an action callback, enabling reuse for both creation and deletion workflows. Also exported CreateAndVerifyObjs for broader usage.

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>

* fix: lint error

---------

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>
nirrozenbaum pushed a commit to llm-d/llm-d-inference-payload-processor that referenced this pull request Apr 28, 2026
@AvineshTripathi
test: refactor Kustomize utils to support delete operations (kubernet…
81c244f 
…es-sigs/gateway-api-inference-extension#2033)

* test: refactor Kustomize utils to support delete operations

Added DeleteAndVerifyObjs and updated CreateCrdsFromKustomize to accept an action callback, enabling reuse for both creation and deletion workflows. Also exported CreateAndVerifyObjs for broader usage.

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>

* fix: lint error

---------

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>
roytman pushed a commit to roytman/llm-d-inference-scheduler that referenced this pull request May 4, 2026
@AvineshTripathi
test: refactor Kustomize utils to support delete operations (kubernet…
fb9ff67 
…es-sigs/gateway-api-inference-extension#2033)

* test: refactor Kustomize utils to support delete operations

Added DeleteAndVerifyObjs and updated CreateCrdsFromKustomize to accept an action callback, enabling reuse for both creation and deletion workflows. Also exported CreateAndVerifyObjs for broader usage.

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>

* fix: lint error

---------

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>
roytman pushed a commit to roytman/llm-d-inference-scheduler that referenced this pull request May 4, 2026
@AvineshTripathi @roytman
test: refactor Kustomize utils to support delete operations (kubernet…
4fe9273 
…es-sigs/gateway-api-inference-extension#2033)

* test: refactor Kustomize utils to support delete operations

Added DeleteAndVerifyObjs and updated CreateCrdsFromKustomize to accept an action callback, enabling reuse for both creation and deletion workflows. Also exported CreateAndVerifyObjs for broader usage.

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>

* fix: lint error

---------

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>
roytman pushed a commit to roytman/llm-d-inference-scheduler that referenced this pull request May 4, 2026
@AvineshTripathi @roytman
test: refactor Kustomize utils to support delete operations (kubernet…
4e24ffc 
…es-sigs/gateway-api-inference-extension#2033)

* test: refactor Kustomize utils to support delete operations

Added DeleteAndVerifyObjs and updated CreateCrdsFromKustomize to accept an action callback, enabling reuse for both creation and deletion workflows. Also exported CreateAndVerifyObjs for broader usage.

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>

* fix: lint error

---------

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>
roytman pushed a commit to roytman/llm-d-inference-scheduler that referenced this pull request May 5, 2026
@AvineshTripathi @roytman
test: refactor Kustomize utils to support delete operations (kubernet…
4dc3543 
…es-sigs/gateway-api-inference-extension#2033)

* test: refactor Kustomize utils to support delete operations

Added DeleteAndVerifyObjs and updated CreateCrdsFromKustomize to accept an action callback, enabling reuse for both creation and deletion workflows. Also exported CreateAndVerifyObjs for broader usage.

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>

* fix: lint error

---------

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>
roytman pushed a commit to roytman/llm-d-inference-scheduler that referenced this pull request May 5, 2026
@AvineshTripathi @roytman
test: refactor Kustomize utils to support delete operations (kubernet…
17ec006 
…es-sigs/gateway-api-inference-extension#2033)

* test: refactor Kustomize utils to support delete operations

Added DeleteAndVerifyObjs and updated CreateCrdsFromKustomize to accept an action callback, enabling reuse for both creation and deletion workflows. Also exported CreateAndVerifyObjs for broader usage.

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>

* fix: lint error

---------

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>
roytman pushed a commit to roytman/llm-d-inference-scheduler that referenced this pull request May 5, 2026
@AvineshTripathi @roytman
test: refactor Kustomize utils to support delete operations (kubernet…
51edf31 
…es-sigs/gateway-api-inference-extension#2033)

* test: refactor Kustomize utils to support delete operations

Added DeleteAndVerifyObjs and updated CreateCrdsFromKustomize to accept an action callback, enabling reuse for both creation and deletion workflows. Also exported CreateAndVerifyObjs for broader usage.

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>

* fix: lint error

---------

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>
roytman pushed a commit to roytman/llm-d-inference-scheduler that referenced this pull request May 5, 2026
@AvineshTripathi @roytman
test: refactor Kustomize utils to support delete operations (kubernet…
444fcfc 
…es-sigs/gateway-api-inference-extension#2033)

* test: refactor Kustomize utils to support delete operations

Added DeleteAndVerifyObjs and updated CreateCrdsFromKustomize to accept an action callback, enabling reuse for both creation and deletion workflows. Also exported CreateAndVerifyObjs for broader usage.

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>

* fix: lint error

---------

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>
roytman pushed a commit to roytman/llm-d-inference-scheduler that referenced this pull request May 5, 2026
@AvineshTripathi @roytman
test: refactor Kustomize utils to support delete operations (kubernet…
409c52d 
…es-sigs/gateway-api-inference-extension#2033)

* test: refactor Kustomize utils to support delete operations

Added DeleteAndVerifyObjs and updated CreateCrdsFromKustomize to accept an action callback, enabling reuse for both creation and deletion workflows. Also exported CreateAndVerifyObjs for broader usage.

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>

* fix: lint error

---------

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danehans danehans Awaiting requested review from danehans

@kfswain kfswain Awaiting requested review from kfswain

Assignees

@ahg-g ahg-g

@kfswain kfswain

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AvineshTripathi @k8s-ci-robot @ahg-g @kfswain