Add optional inference objective by Gregory-Pereira · Pull Request #1995 · kubernetes-sigs/gateway-api-inference-extension

Gregory-Pereira · 2025-12-13T19:03:41Z

What type of PR is this?
/kind cleanup
/kind feature

What this PR does / why we need it:

Enable utilization of the InferenceObjective CR we already have

Does this PR introduce a user-facing change?:
NONE, simply exposes the inferencepool objective in the helm charts

netlify · 2025-12-13T19:03:47Z

✅ Deploy Preview for gateway-api-inference-extension ready!

Name	Link
🔨 Latest commit	`ebb683e`
🔍 Latest deploy log	https://app.netlify.com/projects/gateway-api-inference-extension/deploys/698cb72d3ffe570008871690
😎 Deploy Preview	https://deploy-preview-1995--gateway-api-inference-extension.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

k8s-ci-robot · 2025-12-13T19:03:51Z

Hi @Gregory-Pereira. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

shmuelk · 2025-12-14T09:31:45Z

This PR looks ok, but somehow I think it's missing something.

It is creating a single InferenceObjective with a name that matches the Helm Release Name.

As I understand things the InferenceObjective is referenced by the header x-gateway-inference-objective sent with the request. This is a request related thing. I would expect the ability to create several InferenceObjectives each with a different name and different priority.

Gregory-Pereira · 2025-12-14T20:20:03Z

Good point, I will update the implementation so that users could define all the inference objectives they wish to relate to the inference pool

nirrozenbaum · 2025-12-15T08:45:21Z

/ok-to-test

ahg-g · 2025-12-15T15:33:05Z

Can you please discuss the motivation for this? I see some value, but infObj are a resource that will be created/updated/deleted after creating the infPool; meaning likely new objectives will be added/deleted later.

Gregory-Pereira · 2025-12-15T16:35:19Z

Can you please discuss the motivation for this? I see some value, but infObj are a resource that will be created/updated/deleted after creating the infPool; meaning likely new objectives will be added/deleted later.

I saw the value as automating the creation / deletion of them. In this way they get created and cleaned up with the helm chart. Not to say that others cannot add more out of band. I started on this in preparation for the Flow Control integration work with regard to an LLM-D guide that could showcase the work.

ahg-g · 2025-12-15T16:39:12Z

ok, I can see value in cases where for the most part the objectives are known in advance and mostly static

kfswain · 2025-12-15T23:07:16Z

Agreed with the other comments here. As long as we communicate clearly that there isn't a need to correlate the infObjectives at Pool creation, this all seems reasonable to me

nirrozenbaum · 2025-12-16T07:35:51Z

@Gregory-Pereira the PR overall lgtm.
there is one line to fix (see in poolRef name) and request to enhance the documentation around the inference objectives usage.

Signed-off-by: greg pereira <grpereir@redhat.com>

… over inference objectives Signed-off-by: greg pereira <grpereir@redhat.com>

Signed-off-by: greg pereira <grpereir@redhat.com>

Gregory-Pereira · 2026-02-11T17:08:14Z

I think this is ready for review again if you have cycles @kfswain, @nirrozenbaum or @ahg-g. Sorry it took me so long to get back to this

kfswain · 2026-03-06T04:02:57Z

/approve

LGTM, would like another pair of eyes to help catch anything I may have missed

k8s-ci-robot · 2026-03-06T04:03:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gregory-Pereira, kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [kfswain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

shmuelk · 2026-03-08T09:24:41Z

/lgtm

* enable creating inferenceObjective via the inferencepool helm chart Signed-off-by: greg pereira <grpereir@redhat.com> * updating readme + linting Signed-off-by: greg pereira <grpereir@redhat.com> * allow array of inferencepools Signed-off-by: greg pereira <grpereir@redhat.com> * move inferenceObjective to top level and cleanup template Signed-off-by: greg pereira <grpereir@redhat.com> * remaining cleanup removing the checking of apiVersion when itterating over inference objectives Signed-off-by: greg pereira <grpereir@redhat.com> * document use-case for use infernece-objective values field Signed-off-by: greg pereira <grpereir@redhat.com> --------- Signed-off-by: greg pereira <grpereir@redhat.com>

k8s-ci-robot requested review from nirrozenbaum and shmuelk December 13, 2025 19:03

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 13, 2025

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 13, 2025

nirrozenbaum reviewed Dec 14, 2025

View reviewed changes

Comment thread config/charts/inferencepool/values.yaml Outdated

nirrozenbaum reviewed Dec 14, 2025

View reviewed changes

Comment thread config/charts/inferencepool/templates/inferenceobjective.yaml Outdated

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 15, 2025

Gregory-Pereira force-pushed the add-optional-inference-objective branch from ca76a99 to ff97818 Compare December 15, 2025 15:12

nirrozenbaum reviewed Dec 15, 2025

View reviewed changes

Comment thread config/charts/inferencepool/templates/inferenceobjectives.yaml Outdated

nirrozenbaum reviewed Dec 15, 2025

View reviewed changes

Comment thread config/charts/inferencepool/values.yaml Outdated

Gregory-Pereira force-pushed the add-optional-inference-objective branch 2 times, most recently from 6751dd6 to db76251 Compare December 15, 2025 15:59

nirrozenbaum reviewed Dec 15, 2025

View reviewed changes

Comment thread config/charts/inferencepool/templates/inferenceobjectives.yaml Outdated

nirrozenbaum reviewed Dec 15, 2025

View reviewed changes

Comment thread config/charts/inferencepool/templates/inferenceobjectives.yaml

ahg-g reviewed Dec 15, 2025

View reviewed changes

Comment thread config/charts/inferencepool/README.md Outdated

kfswain reviewed Dec 15, 2025

View reviewed changes

Comment thread config/charts/inferencepool/values.yaml Outdated

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 7, 2026

enable creating inferenceObjective via the inferencepool helm chart

7533416

Signed-off-by: greg pereira <grpereir@redhat.com>

Gregory-Pereira added 4 commits February 11, 2026 08:42

updating readme + linting

cfc200e

Signed-off-by: greg pereira <grpereir@redhat.com>

allow array of inferencepools

bc41e1b

Signed-off-by: greg pereira <grpereir@redhat.com>

move inferenceObjective to top level and cleanup template

c0878a2

Signed-off-by: greg pereira <grpereir@redhat.com>

remaining cleanup removing the checking of apiVersion when itterating…

b2ac7ee

… over inference objectives Signed-off-by: greg pereira <grpereir@redhat.com>

Gregory-Pereira force-pushed the add-optional-inference-objective branch from db76251 to b2ac7ee Compare February 11, 2026 16:44

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2026

document use-case for use infernece-objective values field

ebb683e

Signed-off-by: greg pereira <grpereir@redhat.com>

Gregory-Pereira mentioned this pull request Feb 24, 2026

REQUEST: New membership for Gregory-Pereira to K8s-sigs kubernetes/org#6156

Closed

11 tasks

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2026

k8s-ci-robot assigned shmuelk Mar 8, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2026

k8s-ci-robot merged commit 2fb5fa1 into kubernetes-sigs:main Mar 8, 2026
11 checks passed

Conversation

Gregory-Pereira commented Dec 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Dec 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for gateway-api-inference-extension ready!

Uh oh!

k8s-ci-robot commented Dec 13, 2025

Uh oh!

shmuelk commented Dec 14, 2025

Uh oh!

Gregory-Pereira commented Dec 14, 2025

Uh oh!

Uh oh!

Uh oh!

nirrozenbaum commented Dec 15, 2025

Uh oh!

Uh oh!

ahg-g commented Dec 15, 2025

Uh oh!

Uh oh!

Gregory-Pereira commented Dec 15, 2025

Uh oh!

Uh oh!

ahg-g commented Dec 15, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kfswain commented Dec 15, 2025

Uh oh!

nirrozenbaum commented Dec 16, 2025

Uh oh!

Gregory-Pereira commented Feb 11, 2026

Uh oh!

kfswain commented Mar 6, 2026

Uh oh!

k8s-ci-robot commented Mar 6, 2026

Uh oh!

shmuelk commented Mar 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Gregory-Pereira commented Dec 13, 2025 •

edited

Loading

netlify Bot commented Dec 13, 2025 •

edited

Loading