Skip to content

Use spf13/pflag instead of Go's standard flag package#1979

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
elevran:swap_pflag
Dec 9, 2025
Merged

Use spf13/pflag instead of Go's standard flag package#1979
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
elevran:swap_pflag

Conversation

@elevran
Copy link
Copy Markdown
Contributor

@elevran elevran commented Dec 9, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Use spf13/pflag instead of Go's standard flag package, to align with rest of k8s.
The pflag package is a superset of the standard flag package, so no user visible change is expected.

Which issue(s) this PR fixes:
Ref #1947 for context.

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Etai Lev Ran <elevran@gmail.com>
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 9, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 9, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 386815f
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/693802d49c60fa00086b5c37
😎 Deploy Preview https://deploy-preview-1979--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 9, 2025
@elevran
Copy link
Copy Markdown
Contributor Author

elevran commented Dec 9, 2025

/cc @nirrozenbaum

@nirrozenbaum
Copy link
Copy Markdown
Contributor

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elevran, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit 68a5612 into kubernetes-sigs:main Dec 9, 2025
15 checks passed
@elevran elevran deleted the swap_pflag branch March 18, 2026 09:51
elevran added a commit to llm-d/llm-d-inference-scheduler that referenced this pull request Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants