Skip to content

enhance bbr helm chart to generalize cmd-line args#1900

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
nirrozenbaum:bbr-chart
Nov 25, 2025
Merged

enhance bbr helm chart to generalize cmd-line args#1900
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
nirrozenbaum:bbr-chart

Conversation

@nirrozenbaum
Copy link
Copy Markdown
Contributor

What type of PR is this?

What this PR does / why we need it:
with the expected additions to bbr, this PR is enhancing helm chart to generalize cmd-line arg specification through the helm chart flags (same as done in epp helm chart)

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

None

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 25, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit cb603c8
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6925ac2f75278500088b54a4
😎 Deploy Preview https://deploy-preview-1900--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 25, 2025
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
@shmuelk
Copy link
Copy Markdown
Contributor

shmuelk commented Nov 25, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0419f7f into kubernetes-sigs:main Nov 25, 2025
12 checks passed
@nirrozenbaum nirrozenbaum deleted the bbr-chart branch December 8, 2025 11:25
nirrozenbaum added a commit to llm-d/llm-d-inference-payload-processor that referenced this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants