Skip to content

Add e2e test for multiport InferencePool enhancement#1885

Merged
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
RyanRosario:mpece-2
Dec 15, 2025
Merged

Add e2e test for multiport InferencePool enhancement#1885
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
RyanRosario:mpece-2

Conversation

@RyanRosario
Copy link
Copy Markdown
Contributor

@RyanRosario RyanRosario commented Nov 20, 2025

What type of PR is this?

kind/cleanup

What this PR does / why we need it:

Adds an E2E test for multi-port enhancement. Currently verifyTrafficRouting is implemented, verifyMetrics to follow.

Which issue(s) this PR fixes:

Fixes #1768

Does this PR introduce a user-facing change?:

NONE


@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 20, 2025
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Nov 20, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 20, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 98a9980
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/693e78bf53af60000801b2be
😎 Deploy Preview https://deploy-preview-1885--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 20, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @RyanRosario. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 20, 2025
@RyanRosario RyanRosario changed the title [WIP] Add e2e test for multiport InferencePool enhancement Add e2e test for multiport InferencePool enhancement Nov 25, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2025
@RyanRosario
Copy link
Copy Markdown
Contributor Author

Hey @danehans and @nirrozenbaum , my first PR is ready for review.

@nirrozenbaum
Copy link
Copy Markdown
Contributor

nirrozenbaum commented Nov 25, 2025

/ok-to-test

Thanks @RyanRosario. seems like your PR needs a rebase.
it would be good to solve conflicts in order to see if the tests are passing.

additionally - please pay attention that your commits are not verified and if the PR is ready for review it would be good to remove the /hold to let others know this is ready.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 25, 2025
@RyanRosario
Copy link
Copy Markdown
Contributor Author

/retest

@RyanRosario
Copy link
Copy Markdown
Contributor Author

Thank you for your patience!

The failing test seems to be related to issue 1872. Can we continue with review or should 1872 be resolved first?

Comment thread test/e2e/epp/e2e_suite_test.go Outdated
Comment thread hack/test-e2e.sh Outdated
@nirrozenbaum
Copy link
Copy Markdown
Contributor

Thank you for your patience!

The failing test seems to be related to issue 1872. Can we continue with review or should 1872 be resolved first?

failing test isn't blocking the review but it is blocking the merge.
if this is failing due to a flake, triggering a /retest should solve it (eventually).
if it's failing consistently, we might have a hidden issue here.

Comment thread test/e2e/epp/e2e_test.go Outdated
Comment thread test/e2e/epp/e2e_test.go Outdated
Comment thread test/utils/utils.go Outdated
Comment thread test/utils/utils.go
Comment thread test/e2e/epp/e2e_test.go
@RyanRosario
Copy link
Copy Markdown
Contributor Author

Is this PR ready? anything left to be addressed?

Hi Abdullah, I am working on addressing Luke's feedback but after that I would still need an LGTM in order to get the final stamp, if I understand correctly.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 14, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 14, 2025
@RyanRosario
Copy link
Copy Markdown
Contributor Author

Is this PR ready? anything left to be addressed?

@ahg-g This PR is ready. Luke and I agreed that I would make reasonable changes and those were made. Some can be addressed in a separate PR if necessary.

@ahg-g
Copy link
Copy Markdown
Contributor

ahg-g commented Dec 15, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, RyanRosario

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6c445df into kubernetes-sigs:main Dec 15, 2025
9 checks passed
davidbreitgand pushed a commit to davidbreitgand/gateway-api-inference-extension that referenced this pull request Jan 6, 2026
…#1885)

* Add e2e test for multi-port InferencePool

* Make fixes based on reviewer feedback.

* Address reviewer feedback; remove unusued function

---------

Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
elevran pushed a commit to llm-d/llm-d-inference-scheduler that referenced this pull request Apr 23, 2026
…/gateway-api-inference-extension#1885)

* Add e2e test for multi-port InferencePool

* Make fixes based on reviewer feedback.

* Address reviewer feedback; remove unusued function

---------

Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
nirrozenbaum pushed a commit to llm-d/llm-d-inference-payload-processor that referenced this pull request Apr 28, 2026
…/gateway-api-inference-extension#1885)

* Add e2e test for multi-port InferencePool

* Make fixes based on reviewer feedback.

* Address reviewer feedback; remove unusued function

---------

Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
roytman pushed a commit to roytman/llm-d-inference-scheduler that referenced this pull request May 4, 2026
…/gateway-api-inference-extension#1885)

* Add e2e test for multi-port InferencePool

* Make fixes based on reviewer feedback.

* Address reviewer feedback; remove unusued function

---------

Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
roytman pushed a commit to roytman/llm-d-inference-scheduler that referenced this pull request May 4, 2026
…/gateway-api-inference-extension#1885)

* Add e2e test for multi-port InferencePool

* Make fixes based on reviewer feedback.

* Address reviewer feedback; remove unusued function

---------

Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
roytman pushed a commit to roytman/llm-d-inference-scheduler that referenced this pull request May 4, 2026
…/gateway-api-inference-extension#1885)

* Add e2e test for multi-port InferencePool

* Make fixes based on reviewer feedback.

* Address reviewer feedback; remove unusued function

---------

Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
roytman pushed a commit to roytman/llm-d-inference-scheduler that referenced this pull request May 5, 2026
…/gateway-api-inference-extension#1885)

* Add e2e test for multi-port InferencePool

* Make fixes based on reviewer feedback.

* Address reviewer feedback; remove unusued function

---------

Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
roytman pushed a commit to roytman/llm-d-inference-scheduler that referenced this pull request May 5, 2026
…/gateway-api-inference-extension#1885)

* Add e2e test for multi-port InferencePool

* Make fixes based on reviewer feedback.

* Address reviewer feedback; remove unusued function

---------

Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
roytman pushed a commit to roytman/llm-d-inference-scheduler that referenced this pull request May 5, 2026
…/gateway-api-inference-extension#1885)

* Add e2e test for multi-port InferencePool

* Make fixes based on reviewer feedback.

* Address reviewer feedback; remove unusued function

---------

Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
roytman pushed a commit to roytman/llm-d-inference-scheduler that referenced this pull request May 5, 2026
…/gateway-api-inference-extension#1885)

* Add e2e test for multi-port InferencePool

* Make fixes based on reviewer feedback.

* Address reviewer feedback; remove unusued function

---------

Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
roytman pushed a commit to roytman/llm-d-inference-scheduler that referenced this pull request May 5, 2026
…/gateway-api-inference-extension#1885)

* Add e2e test for multi-port InferencePool

* Make fixes based on reviewer feedback.

* Address reviewer feedback; remove unusued function

---------

Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update E2E tests to include multiport case

6 participants