Add e2e test for multiport InferencePool enhancement#1885
Add e2e test for multiport InferencePool enhancement#1885k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @RyanRosario. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hey @danehans and @nirrozenbaum , my first PR is ready for review. |
|
/ok-to-test Thanks @RyanRosario. seems like your PR needs a rebase. additionally - please pay attention that your commits are not verified and if the PR is ready for review it would be good to remove the |
|
/retest |
|
Thank you for your patience! The failing test seems to be related to issue 1872. Can we continue with review or should 1872 be resolved first? |
failing test isn't blocking the review but it is blocking the merge. |
Hi Abdullah, I am working on addressing Luke's feedback but after that I would still need an LGTM in order to get the final stamp, if I understand correctly. |
@ahg-g This PR is ready. Luke and I agreed that I would make reasonable changes and those were made. Some can be addressed in a separate PR if necessary. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, RyanRosario The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…#1885) * Add e2e test for multi-port InferencePool * Make fixes based on reviewer feedback. * Address reviewer feedback; remove unusued function --------- Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
…/gateway-api-inference-extension#1885) * Add e2e test for multi-port InferencePool * Make fixes based on reviewer feedback. * Address reviewer feedback; remove unusued function --------- Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
…/gateway-api-inference-extension#1885) * Add e2e test for multi-port InferencePool * Make fixes based on reviewer feedback. * Address reviewer feedback; remove unusued function --------- Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
…/gateway-api-inference-extension#1885) * Add e2e test for multi-port InferencePool * Make fixes based on reviewer feedback. * Address reviewer feedback; remove unusued function --------- Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
…/gateway-api-inference-extension#1885) * Add e2e test for multi-port InferencePool * Make fixes based on reviewer feedback. * Address reviewer feedback; remove unusued function --------- Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
…/gateway-api-inference-extension#1885) * Add e2e test for multi-port InferencePool * Make fixes based on reviewer feedback. * Address reviewer feedback; remove unusued function --------- Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
…/gateway-api-inference-extension#1885) * Add e2e test for multi-port InferencePool * Make fixes based on reviewer feedback. * Address reviewer feedback; remove unusued function --------- Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
…/gateway-api-inference-extension#1885) * Add e2e test for multi-port InferencePool * Make fixes based on reviewer feedback. * Address reviewer feedback; remove unusued function --------- Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
…/gateway-api-inference-extension#1885) * Add e2e test for multi-port InferencePool * Make fixes based on reviewer feedback. * Address reviewer feedback; remove unusued function --------- Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
…/gateway-api-inference-extension#1885) * Add e2e test for multi-port InferencePool * Make fixes based on reviewer feedback. * Address reviewer feedback; remove unusued function --------- Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
…/gateway-api-inference-extension#1885) * Add e2e test for multi-port InferencePool * Make fixes based on reviewer feedback. * Address reviewer feedback; remove unusued function --------- Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
What type of PR is this?
kind/cleanup
What this PR does / why we need it:
Adds an E2E test for multi-port enhancement. Currently verifyTrafficRouting is implemented, verifyMetrics to follow.
Which issue(s) this PR fixes:
Fixes #1768
Does this PR introduce a user-facing change?:
NONE