fix training server indentation bug and test yaml to build script #1854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
cncf-cla: yes
Contributor
|
/lgtm please remove the hold if @BenjaminBraunDev reviewed this |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, kaushikmitr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
|
Reviewed, this LGTM |
Contributor
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
rlakhtakia
pushed a commit
to rlakhtakia/gateway-api-inference-extension
that referenced
this pull request
Nov 17, 2025
…bernetes-sigs#1854) * fix training server indentation bug and test yaml to build script * add boilerplate header to build deploy script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the
latencypredictor/build-deploy.shscript and refactors quantile metric calculations intraining_server.pyto improve test automation and model evaluation. The build/deploy script now supports building, pushing, and deploying a dedicated test image and job, providing comprehensive testing capabilities. The training server code is refactored to ensure consistent feature engineering and column selection for quantile metric calculations, reducing errors and improving maintainability.Build and deployment automation:
build-deploy.shfor building, tagging, and pushing a dedicated test Docker image (latencypredictor-test) whenDockerfile-testis present, including logic to skip test image steps if the file is missing. [1] [2] [3] [4]test-job.yamlmanifest if missing, run tests via the test image, and clean up test jobs after execution.Model evaluation and feature engineering:
_calculate_quantile_metrics_on_testintraining_server.pyto consistently apply feature engineering and select feature columns based on model type and name, improving reliability and reducing manual errors._calculate_quantile_metrics_on_testin the training workflow to pass raw test data and model names, ensuring feature columns are determined internally and consistently. [1] [2]