Add automatic TLS certificate reloading for EPP#1765
Merged
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom Dec 3, 2025
Merged
Add automatic TLS certificate reloading for EPP#1765k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
the
kind/feature
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
Hi @pierDipi. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
needs-ok-to-test
pierDipi
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
pierDipi
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
Author
Collaborator
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
Enables the server to reload certificates without restart when they are rotated, which is particularly useful in Kubernetes environments where certificate rotation is automated. Adds --enable-cert-refresh flag (default: false) to control this behavior. Uses file watching with debouncing to handle rapid file system events during certificate updates. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
avoid the case where defer of the goroutine is called before w.Add Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
cert-reload
branch
from
aba360d to
e488bae
Compare
k8s-ci-robot
removed
the
needs-rebase
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Contributor
Author
|
@nirrozenbaum @kfswain @danehans please take a look |
nirrozenbaum
reviewed
Dec 3, 2025
| limitations under the License. | ||
| */ | ||
|
|
||
| package common |
Contributor
There was a problem hiding this comment.
nit/question (not a blocker):
is certs under common cause you consider using it also in bbr (in the future)?
Contributor
Author
There was a problem hiding this comment.
yes, BBR and routing sidecar on the llm-d side
Contributor
|
sorry for the long delays with the review! /lgtm Thanks! |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
11 tasks
elevran
pushed a commit
to llm-d/llm-d-inference-scheduler
that referenced
this pull request
Apr 23, 2026
…way-api-inference-extension#1765) * Add automatic TLS certificate reloading for EPP Enables the server to reload certificates without restart when they are rotated, which is particularly useful in Kubernetes environments where certificate rotation is automated. Adds --enable-cert-refresh flag (default: false) to control this behavior. Uses file watching with debouncing to handle rapid file system events during certificate updates. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Add path to watch before before creating background gorouting avoid the case where defer of the goroutine is called before w.Add Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Debug level logging returns error Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
nirrozenbaum
pushed a commit
to llm-d/llm-d-inference-payload-processor
that referenced
this pull request
Apr 28, 2026
…way-api-inference-extension#1765) * Add automatic TLS certificate reloading for EPP Enables the server to reload certificates without restart when they are rotated, which is particularly useful in Kubernetes environments where certificate rotation is automated. Adds --enable-cert-refresh flag (default: false) to control this behavior. Uses file watching with debouncing to handle rapid file system events during certificate updates. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Add path to watch before before creating background gorouting avoid the case where defer of the goroutine is called before w.Add Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Debug level logging returns error Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
elevran
pushed a commit
to llm-d/llm-d-inference-scheduler
that referenced
this pull request
May 3, 2026
…way-api-inference-extension#1765) * Add automatic TLS certificate reloading for EPP Enables the server to reload certificates without restart when they are rotated, which is particularly useful in Kubernetes environments where certificate rotation is automated. Adds --enable-cert-refresh flag (default: false) to control this behavior. Uses file watching with debouncing to handle rapid file system events during certificate updates. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Add path to watch before before creating background gorouting avoid the case where defer of the goroutine is called before w.Add Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Debug level logging returns error Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Enables the server to reload certificates without restart when they are rotated, which is particularly useful in Kubernetes environments where certificate rotation is automated.
Adds
--enable-cert-reloadflag (default: false) to control this behavior. Uses file watching with debouncing to handle rapid file system events during certificate updates.Does this PR introduce a user-facing change?: