Skip to content

Cleanup helm flags which have default values from values yaml #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2025
Merged

Cleanup helm flags which have default values from values yaml #1429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc20338
Cleanup flags with default values in values yaml
rahulgurnani Aug 21, 2025
8278aa7
Update README.md
rahulgurnani Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions config/charts/inferencepool/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,18 +83,18 @@ $ helm install triton-llama3-8b-instruct \

To deploy the EndpointPicker in a high-availability (HA) active-passive configuration, you can enable leader election. When enabled, the EPP deployment will have multiple replicas, but only one "leader" replica will be active and ready to process traffic at any given time. If the leader pod fails, another pod will be elected as the new leader, ensuring service continuity.

To enable HA, set `inferenceExtension.enableLeaderElection` to `true` and increase the number of replicas in your `values.yaml` file:
To enable HA, set `inferenceExtension.flags.has-enable-leader-election` to `true` and increase the number of replicas in your `values.yaml` file:

```yaml
inferenceExtension:
replicas: 3
enableLeaderElection: true
has-enable-leader-election: true
```

Then apply it with:

```txt
helm install vllm-llama3-8b-instruct ./config/charts/inferencepool -f values.yaml \
helm install vllm-llama3-8b-instruct ./config/charts/inferencepool -f values.yaml
```

## Uninstall
Expand Down Expand Up @@ -122,10 +122,9 @@ The following table list the configurable parameters of the chart.
| `inferenceExtension.env` | List of environment variables to set in the endpoint picker container as free-form YAML. Defaults to `[]`. |
| `inferenceExtension.extraContainerPorts` | List of additional container ports to expose. Defaults to `[]`. |
| `inferenceExtension.extraServicePorts` | List of additional service ports to expose. Defaults to `[]`. |
| `inferenceExtension.flags` | List of flags which are passed through to endpoint picker. |
| `inferenceExtension.flags` | List of flags which are passed through to endpoint picker. Example flags, enable-pprof, grpc-port etc. Refer [runner.go](https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/cmd/epp/runner/runner.go) for complete list. |
| `inferenceExtension.flags.has-enable-leader-election` | Enable leader election for high availability. When enabled, only one EPP pod (the leader) will be ready to serve traffic. |
| `provider.name` | Name of the Inference Gateway implementation being used. Possible values: `gke`. Defaults to `none`. |
| `inferenceExtension.enableLeaderElection` | Enable leader election for high availability. When enabled, only one EPP pod (the leader) will be ready to serve traffic. It is recommended to set `inferenceExtension.replicas` to a value greater than 1 when this is set to `true`. Defaults to `false`. |
Copy link
Contributor

@liu-cong liu-cong Aug 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading inferenceExtension.flags.has-enable-leader-election is a bit confusing as it looks like a special flag. At least we should document as part of the flags section.

Can we update the documentation like I suggested in the previous PR #1302 (comment) , basically document this as part of the flags section, provide a concrete example, and list has-enable-leader-election as an important example flag.

Copy link
Contributor Author

@rahulgurnani rahulgurnani Aug 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. I think referring to values.yaml for example is more suitable. Let me know what you think.. Thanks!

Copy link
Collaborator

@kfswain kfswain Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the way its formatted currently would allow this key info to be easily skipped by a reader. I agree with @liu-cong that we should probably bullet list a couple important flags, and then the last bullet can be your link to the exhaustive list.

Copy link
Contributor Author

@rahulgurnani rahulgurnani Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reformatted the flags. I think they are more readable in the README. Also added a sample instruction on the top. Thanks!



## Notes

Expand Down
42 changes: 0 additions & 42 deletions config/charts/inferencepool/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,51 +32,9 @@ inferenceExtension:
# ENABLE_EXPERIMENTAL_FEATURE: "true"

flags:
- name: grpc-port
value: 9002
- name: grpc-health-port
value: 9003
- name: metrics-port
value: 9090
- name: enable-pprof
value: "true" # Enable pprof handlers for profiling and debugging
- name: pool-group
value: "inference.networking.k8s.io"
# Log verbosity
- name: v
value: 1
- name: secure-serving
value: "true"
- name: health-checking
value: "false"
- name: cert-path
value: ""
- name: total-queued-requests-metric
value: "vllm:num_requests_waiting"
- name: kv-cache-usage-percentage-metric
value: "vllm:gpu_cache_usage_perc"
- name: lora-info-metric
value: "vllm:lora_requests_info"
- name: refresh-metrics-interval
value: "50ms"
- name: refresh-prometheus-metrics-interval
value: "5s"
- name: metrics-staleness-threshold
value: "2s"
- name: config-file
value: ""
- name: config-text
value: ""
- name: model-server-metrics-port
value: 0
- name: model-server-metrics-path
value: "/metrics"
- name: model-server-metrics-scheme
value: "http"
- name: model-server-metrics-https-insecure-skip-verify
value: "true"
- name: has-enable-leader-election
value: false

inferencePool:
targetPorts:
Expand Down