Skip to content

Conversation

@zetxqx
Copy link
Contributor

@zetxqx zetxqx commented Aug 2, 2025

The original make target does not generate any image, see the following command and result

❯ make image-push
make: Nothing to be done for 'image-push'.

Moving the $(MULTI) to build.yaml instead of putting it in the make target. Because it won't evaluate because
while MULTI is only read at parse time (by the ifdef MULTI block)

However, I didn't verify if the cloud build can generate multiple platform image. We can merge this PR and see the post submit.

@netlify
Copy link

netlify bot commented Aug 2, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 69c793b
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/688d89074256a80008209a24
😎 Deploy Preview https://deploy-preview-1286--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 2, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and liu-cong August 2, 2025 03:42
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 2, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @zetxqx. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 2, 2025
@danehans
Copy link
Contributor

danehans commented Aug 2, 2025

+1 on merging to see if post submit will build the multi-arch image.

@danehans
Copy link
Contributor

danehans commented Aug 2, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 2, 2025
@danehans
Copy link
Contributor

danehans commented Aug 2, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, zetxqx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit 48c7c44 into kubernetes-sigs:main Aug 2, 2025
8 of 9 checks passed
@kfswain
Copy link
Collaborator

kfswain commented Aug 3, 2025

builds time out now unfortunately

danehans added a commit that referenced this pull request Aug 4, 2025
This reverts commit 48c7c44.
k8s-ci-robot pushed a commit that referenced this pull request Aug 4, 2025
@zetxqx zetxqx deleted the fixbuild branch September 29, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants