Skip to content

Conversation

@nirrozenbaum
Copy link
Contributor

this flag is no longer used (was removed from main)

@netlify
Copy link

netlify bot commented Jul 14, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 371b11e
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6875d05b872a030008db26cb
😎 Deploy Preview https://deploy-preview-1157--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 14, 2025
@k8s-ci-robot k8s-ci-robot requested review from kfswain and robscott July 14, 2025 20:36
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 14, 2025
@kfswain
Copy link
Collaborator

kfswain commented Jul 14, 2025

/lgtm
/approve

IDK about you, but pure code removal PRs make me happy

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kfswain,nirrozenbaum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2025
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 15, 2025
@nirrozenbaum nirrozenbaum deleted the rm-use-streaming branch July 15, 2025 05:55
@nirrozenbaum nirrozenbaum restored the rm-use-streaming branch July 15, 2025 16:32
@nirrozenbaum nirrozenbaum reopened this Jul 15, 2025
@nirrozenbaum
Copy link
Contributor Author

@kfswain closed by mistake (probably was too tired)

@kfswain
Copy link
Collaborator

kfswain commented Jul 15, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9e50fa2 into kubernetes-sigs:main Jul 15, 2025
9 checks passed
@nirrozenbaum nirrozenbaum deleted the rm-use-streaming branch July 15, 2025 21:21
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants