-
Notifications
You must be signed in to change notification settings - Fork 207
feat(conformance): loose the InferencePoolInvalidEPPService to only check httpRoute is accepted true. #1131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…heck httpRoute is accespted true.
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @zetxqx. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This looks reasonable to me, thanks @zetxqx! /lgtm |
|
/assign kfswain Hi Kellen, could you take a look for approval? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain, zetxqx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…heck httpRoute is accespted true. (kubernetes-sigs#1131)
Currently when the EPP does not exist, the test case is also checking if the httpRoute is resolvedDefs to true. However, this is not specified in the API spec. Also, showing resolvedDefs to false on httpRoute is more user-friendly as well.
the following is the condition status of httpRoute on my dev environment for gke-l7
Run test against my gke dev environment: