Skip to content

Conversation

@zetxqx
Copy link
Contributor

@zetxqx zetxqx commented Jul 9, 2025

Currently when the EPP does not exist, the test case is also checking if the httpRoute is resolvedDefs to true. However, this is not specified in the API spec. Also, showing resolvedDefs to false on httpRoute is more user-friendly as well.

the following is the condition status of httpRoute on my dev environment for gke-l7

Status:
  Parents:
    Conditions:
      Last Transition Time:  2025-07-09T18:01:13Z
      Message:               error cause: reference-not-found: Error GWCER104: HTTPRoute "gateway-conformance-app-backend/httproute-for-invalid-epp-pool" is misconfigured, err: failed to validate inference pool extension ref: InferencePool extension service non-existent-epp-svc not found.
      Observed Generation:   1
      Reason:                BackendNotFound
      Status:                False
      Type:                  ResolvedRefs
      Last Transition Time:  2025-07-09T18:01:13Z
      Message:               
      Observed Generation:   1
      Reason:                Accepted
      Status:                True
      Type:                  Accepted
      Last Transition Time:  2025-07-09T18:01:13Z
      Message:               
      Observed Generation:   1
      Reason:                ReconciliationSucceeded
      Status:                True
      Type:                  Reconciled
    Controller Name:         networking.gke.io/gateway
    Parent Ref:
      Group:      gateway.networking.k8s.io
      Kind:       Gateway
      Name:       conformance-primary-gateway
      Namespace:  gateway-conformance-infra

Run test against my gke dev environment:

=== NAME  TestConformance
    suite.go:451: 2025-07-09T17:23:37.485689977Z: Sleeping 0s for test isolation
=== RUN   TestConformance/HTTPRouteMultipleRulesDifferentPools
    conformance.go:68: Skipping HTTPRouteMultipleRulesDifferentPools: test explicitly skipped
=== NAME  TestConformance
    suite.go:451: 2025-07-09T17:23:37.486503348Z: Sleeping 0s for test isolation
=== RUN   TestConformance/InferencePoolResolvedRefsCondition
    conformance.go:68: Skipping InferencePoolResolvedRefsCondition: test explicitly skipped
--- PASS: TestConformance (186.31s)
...
    --- SKIP: TestConformance/InferencePoolHTTPRoutePortValidation (0.00s)
    --- PASS: TestConformance/InferencePoolInvalidEPPService (85.49s)
        --- PASS: TestConformance/InferencePoolInvalidEPPService/InferecePool_has_a_ResolvedRefs_Condition_with_status_False (0.04s)
        --- PASS: TestConformance/InferencePoolInvalidEPPService/Request_to_a_route_with_an_invalid_backend_reference_receives_a_500_response (30.13s)
    --- SKIP: TestConformance/HTTPRouteMultipleRulesDifferentPools (0.00s)
    --- SKIP: TestConformance/InferencePoolResolvedRefsCondition (0.00s)
PASS
ok  	sigs.k8s.io/gateway-api-inference-extension/conformance	186.546s

@netlify
Copy link

netlify bot commented Jul 9, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit f8668a4
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/686eaef105a2d1000810e266
😎 Deploy Preview https://deploy-preview-1131--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 9, 2025
@k8s-ci-robot k8s-ci-robot requested review from danehans and kfswain July 9, 2025 18:03
@k8s-ci-robot
Copy link
Contributor

Hi @zetxqx. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 9, 2025
@robscott
Copy link
Member

robscott commented Jul 9, 2025

This looks reasonable to me, thanks @zetxqx!

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 9, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2025
@zetxqx
Copy link
Contributor Author

zetxqx commented Jul 9, 2025

/assign kfswain

Hi Kellen, could you take a look for approval?

@kfswain
Copy link
Collaborator

kfswain commented Jul 10, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain, zetxqx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit a4a6ab4 into kubernetes-sigs:main Jul 10, 2025
9 checks passed
@zetxqx zetxqx deleted the loosecase branch July 29, 2025 23:14
BenjaminBraunDev pushed a commit to BenjaminBraunDev/gateway-api-inference-extension that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants