-
Notifications
You must be signed in to change notification settings - Fork 284
Clean up prepareRequest #1744
Copy link
Copy link
Closed as not planned
Labels
lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.
Metadata
Metadata
Assignees
Labels
lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.
This PR: #1738 revealed the need for a refactor, we really shouldnt be doing validation on the number of ports at this stage in the request lifecycle. We should refactor and express these as
endpointsas each endpoint will have its port associated with itself already