chore(source): standardize sources - #6089
Merged
k8s-ci-robot merged 12 commits intoJan 21, 2026
Merged
Conversation
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
ivankatliarchuk
marked this pull request as draft
January 9, 2026 11:06
Pull Request Test Coverage Report for Build 21064023875Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
ivankatliarchuk
marked this pull request as ready for review
January 9, 2026 14:29
vflaux
suggested changes
Jan 14, 2026
Co-authored-by: vflaux <38909103+vflaux@users.noreply.github.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
vflaux
reviewed
Jan 16, 2026
Co-authored-by: vflaux <38909103+vflaux@users.noreply.github.com>
vflaux
reviewed
Jan 20, 2026
Contributor
|
/lgtm |
Member
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivankatliarchuk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do ?
This PR standardizes controller mismatch checking and empty endpoint logging across all source implementations by extracting duplicated logic into reusable helper functions.
New helper functions
endpoint.HasEmptyEndpoints()(file created endpoint/utils.go similar to source/utils.go)- Checks if endpoint list is empty and logs a standardized debug message
- Returns true if empty, false otherwise
annotations.IsControllerMismatch()(source/annotations/processors.go)- Checks if a resource should be skipped due to controller annotation not matching
- Logs a standardized debug message when skipping
Motivation
More