Skip to content

Conversation

@mloiseleur
Copy link
Collaborator

@mloiseleur mloiseleur commented Jun 8, 2025

What does it do ?

Update schema with latest plugin release: v1.9.0

Motivation

Fix CI, like this one from #5493

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. chart labels Jun 8, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 8, 2025
@ivankatliarchuk
Copy link
Member

I'm getting similar error, but only in end-2-end prow instance #5509 (comment)

I think is related to this PR #5470 but could be wrong

@mloiseleur
Copy link
Collaborator Author

/retest

@mloiseleur
Copy link
Collaborator Author

@ivankatliarchuk I opened #5514 to fix the flaky test. There was a double call to t.Parallel.

@ivankatliarchuk
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2025
@mloiseleur
Copy link
Collaborator Author

/assign @stevehipwell for final review

@stevehipwell
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2025
@ivankatliarchuk
Copy link
Member

/test pull-external-dns-unit-test

@k8s-ci-robot k8s-ci-robot merged commit 615cf8d into kubernetes-sigs:master Jun 11, 2025
15 checks passed
@mloiseleur mloiseleur deleted the chore/schema branch June 12, 2025 07:20
ivankatliarchuk added a commit to gofogo/k8s-sigs-external-dns-fork that referenced this pull request Jun 12, 2025
* master:
  fix(chart): update schema with latest plugin release (kubernetes-sigs#5510)
  chore(deps): bump the dev-dependencies group with 10 updates (kubernetes-sigs#5519)
  feat: Plan normalizeDNSName convert Unicode to ASCII (kubernetes-sigs#5049)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. chart cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants