Skip to content

fix: ovh: correct handling of records deletion #5450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jun 8, 2025
Merged

fix: ovh: correct handling of records deletion #5450

k8s-ci-robot merged 1 commit into from
Jun 8, 2025

Conversation

@rbeuque74
Copy link
Contributor

@rbeuque74 rbeuque74 commented May 22, 2025

What does it do ?

Fixing OVH provider latest release

Motivation

Report from #5407

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 22, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 22, 2025

Hi @rbeuque74. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 22, 2025
@rbeuque74 rbeuque74 mentioned this pull request May 22, 2025
Closed
@rbeuque74
Copy link
Contributor Author

rbeuque74 commented May 22, 2025

Sorry for the bug introduction, my external-dns setup was not correct, and the deletion process was not done during my tests (policy was upsert-only :/)

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 22, 2025
@ivankatliarchuk
Copy link
Member

ivankatliarchuk commented May 22, 2025

/ok-to-test

@mloiseleur
Copy link
Collaborator

mloiseleur commented May 22, 2025

/ok-to-test
@kevinvalk Can you confirm this PR fixes your issue ? (how to test a PR)

@kevinvalk
Copy link
Contributor

kevinvalk commented May 25, 2025

/ok-to-test @kevinvalk Can you confirm this PR fixes your issue ? (how to test a PR)

Thanks @rbeuque74 for the work!

Yes, put it on my (sadly too long) TODO list. Will keep you posted!

@kevinvalk
Copy link
Contributor

kevinvalk commented Jun 7, 2025 •
edited
Loading

@mloiseleur can confirm it works based on the following non-exhaustive test:

  • I observed the crash again
  • Scaled down the deployment in-cluster
  • Ran the PR locally with exactly the same arguments as in-cluster
  • Service was deleted without errors

/lgtm

ivankatliarchuk
ivankatliarchuk approved these changes Jun 8, 2025
View reviewed changes
Copy link
Member

@ivankatliarchuk ivankatliarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2025
@k8s-ci-robot k8s-ci-robot merged commit 226c45e into kubernetes-sigs:master Jun 8, 2025
17 checks passed
ivankatliarchuk added a commit to gofogo/k8s-sigs-external-dns-fork that referenced this pull request Jun 10, 2025
@ivankatliarchuk
Merge branch 'master' into feat-pod-add-support-for-fqdn
b93ddf8 
* master:
  test(source): fix flaky test (kubernetes-sigs#5514)
  chore(source/node): added resouce labels for nodes (kubernetes-sigs#5509)
  chore(deps): bump the dev-dependencies group across 1 directory with 14 updates (kubernetes-sigs#5511)
  fix(ovh): correct handling of records deletion (kubernetes-sigs#5450)
@rbeuque74 rbeuque74 deleted the fix-ovh branch June 23, 2025 06:28
This was referenced Jun 25, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szuecs szuecs Awaiting requested review from szuecs

1 more reviewer

@ivankatliarchuk ivankatliarchuk ivankatliarchuk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ivankatliarchuk ivankatliarchuk

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rbeuque74 @k8s-ci-robot @ivankatliarchuk @mloiseleur @kevinvalk