Skip to content

Conversation

@zengyuxing007
Copy link
Contributor

Description

docs update: add alibaba cloud provider reference

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 20, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @zengyuxing007!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 20, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @zengyuxing007. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 20, 2025
@ivankatliarchuk
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 20, 2025
@mloiseleur
Copy link
Collaborator

We have started a process to move providers out of the tree, see this issue for more details. So, I have mixed feeling about this PR.

As I said to @mozillazg, I invite you to create a webhook provider.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2025
@zengyuxing007
Copy link
Contributor Author

zengyuxing007 commented May 21, 2025

We have started a process to move providers out of the tree, see this issue for more details. So, I have mixed feeling about this PR.

As I said to @mozillazg, I invite you to create a webhook provider. /hold

@mloiseleur but you know that the Alibaba Cloud DNS Provider have exsisted under this repo,I will be responsible for the implementation of this provider, including bug fixes, to ensure its functionality is working properly.

btw, We also provide the external-dns component to our customers under the ACK product, so it will definitely be maintained in the long term.

thanks

@mloiseleur
Copy link
Collaborator

@mloiseleur but you know that the Alibaba Cloud DNS Provider have exsisted under this repo

We have started the process to move providers out of tree.
So yes, most of the providers we move have existed in this repository. See

Does that answer your question ?

@szuecs
Copy link
Contributor

szuecs commented May 27, 2025

@zengyuxing007 our plan is to move all providers out of tree sooner or later. Alibaba will of course one of the later ones, but also AWS will be moved out of tree. So please check the webhook provider and test it.
Docs can be linked from here, so I think we should merge this PR.

@mloiseleur
Copy link
Collaborator

@szuecs I agree with you on this specific PR.
/hold cancel
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3731ff6 into kubernetes-sigs:master May 28, 2025
16 checks passed
@zengyuxing007
Copy link
Contributor Author

@zengyuxing007 our plan is to move all providers out of tree sooner or later. Alibaba will of course one of the later ones, but also AWS will be moved out of tree. So please check the webhook provider and test it. Docs can be linked from here, so I think we should merge this PR.

@szuecs ok, i'll do that, thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants