feat(pihole): add support for IPv6 Dual format

[tJouve]

Description

Fixes #5251

This PR add support for IPv6 Dual with the following format : y:y:y:y:y:y:x.x.x.x

PiHole support such IPs but previous implementations did not take it in account.
External DNS was able to push such record, but can not read it from the provider (the record was filtered out because mark as IPV6 but containing a '.' . Finally External DNS try to push again the record but the provider return an error because the record is duplicated.

This implementation fix this and the test used to determine if it is an IPv4 or IPv6 is more robust.

Also get rid of instrumented_http, httpClient is enough. See #5226 (comment) .

No change done on the V5 implementation as it is now deprecated.

Checklist

• Unit tests updated
• End user documentation updated

[k8s-ci-robot]

Hi @tJouve. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ivankatliarchuk]

instrumented_http configures http metrics...

[ivankatliarchuk]

/ok-to-test
/label tide/merge-method-squash

[ivankatliarchuk]

instead of

out = append(out, &endpoint.Endpoint{
			DNSName:    DNSName,
			Targets:    []string{Target},
			RecordTTL:  Ttl,
			RecordType: rtype,
})

could we use, this will help us improve code at some

NewEndpoint()...

[tJouve]

instrumented_http configures http metrics...

I rollback this one

[ivankatliarchuk]

/lgtm

may need someone to validate where or not it solves a problem

[tJouve]

@tholinka is it ok for you to test this one ?

[tholinka]

It works without crashing now, all records show up in Pi-Hole as expected!

The logs do get spammed with invalid format received from PiHole every run though:

It seems like it's trying to parse every A and AAAA record as AAAA and A as well.

time="2025-04-07T18:40:04-05:00" level=info msg="PUT internal.domain.name IN AAAA -> ::ffff:192.168.20.3"
time="2025-04-07T18:40:04-05:00" level=info msg="PUT internal.domain.name IN A -> 192.168.20.3"
time="2025-04-07T18:40:04-05:00" level=info msg="PUT external.domain.name IN A -> 192.168.20.4"
time="2025-04-07T18:40:04-05:00" level=info msg="PUT external.domain.name IN AAAA -> ::ffff:192.168.20.4"
time="2025-04-07T18:41:04-05:00" level=warning msg="skipping A record ::ffff:192.168.20.3 internal.domain.name: invalid format received from PiHole"
time="2025-04-07T18:41:04-05:00" level=warning msg="skipping A record ::ffff:192.168.20.4 external.domain.name: invalid format received from PiHole"
time="2025-04-07T18:41:05-05:00" level=warning msg="skipping AAAA record 192.168.20.3 internal.domain.name: invalid format received from PiHole"
time="2025-04-07T18:41:05-05:00" level=warning msg="skipping AAAA record 192.168.20.4 external.domain.name: invalid format received from PiHole"
time="2025-04-07T18:41:05-05:00" level=info msg="All records are already up to date"
time="2025-04-07T18:42:04-05:00" level=warning msg="skipping A record ::ffff:192.168.20.3 internal.domain.name: invalid format received from PiHole"
time="2025-04-07T18:42:04-05:00" level=warning msg="skipping A record ::ffff:192.168.20.4 external.domain.name: invalid format received from PiHole"
time="2025-04-07T18:42:05-05:00" level=warning msg="skipping AAAA record 192.168.20.3 internal.domain.name: invalid format received from PiHole"
time="2025-04-07T18:42:05-05:00" level=warning msg="skipping AAAA record 192.168.20.4 external.domain.name: invalid format received from PiHole"
time="2025-04-07T18:42:05-05:00" level=info msg="All records are already up to date"

[tJouve]

crashing now, all records show up in Pi-Hole as expected!

OK, I removed the logs because it is a normal behaviour : PiHole return both A and AAAA records. So it is normal to filter out some records

[tholinka]

Deployed the newest commit and it's working

[k8s-ci-robot]

@tholinka: changing LGTM is restricted to collaborators

Details

In response to this:

Deployed the newest commit and it's working

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ivankatliarchuk]

cc: @mloiseleur

[mloiseleur]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk, mloiseleur, tholinka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mloiseleur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment