✨ Add namespaceSelector and objectSelector to webhook markers#1339
Open
camilamacedo86 wants to merge 1 commit intokubernetes-sigs:mainfrom
Open
✨ Add namespaceSelector and objectSelector to webhook markers#1339camilamacedo86 wants to merge 1 commit intokubernetes-sigs:mainfrom
camilamacedo86 wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XXL
camilamacedo86
force-pushed
the
namespaceSelector
branch
2 times, most recently
from
dad1fdb to
752154a
Compare
Member
Author
|
@sbueringer @JoelSpeed WDYT? |
JoelSpeed
reviewed
Feb 16, 2026
pkg/webhook/parser.go
Outdated
| // namespaceSelector=matchLabels~team=platform&matchExpressions~key=tier.operator=NotIn.values=system | ||
| // | ||
| // Operators: In, NotIn, Exists, DoesNotExist | ||
| // Syntax: ~ separates selector type, . separates fields, & combines selectors, | separates values |
Contributor
There was a problem hiding this comment.
What if we just allowed the user to write a JSON object representing a namespace selector, rather than coming up with some complex syntax?
Member
Author
There was a problem hiding this comment.
Done. Good idea 👍
camilamacedo86
force-pushed
the
namespaceSelector
branch
from
752154a to
7cd4915
Compare
k8s-ci-robot
added
size/XL
camilamacedo86
force-pushed
the
namespaceSelector
branch
from
7cd4915 to
3abcd99
Compare
k8s-ci-robot
added
needs-rebase
camilamacedo86
force-pushed
the
namespaceSelector
branch
from
3abcd99 to
9ed010f
Compare
k8s-ci-robot
removed
the
needs-rebase
camilamacedo86
force-pushed
the
namespaceSelector
branch
from
9ed010f to
7b52289
Compare
k8s-ci-robot
added
size/XL
camilamacedo86
force-pushed
the
namespaceSelector
branch
2 times, most recently
from
c895a1b to
a26f666
Compare
Enables filtering webhooks by namespace and object labels to solve the webhook bootstrap problem and support namespace-scoped operators. Assisted-by: Cursor/Claude
camilamacedo86
force-pushed
the
namespaceSelector
branch
from
a26f666 to
de97a6a
Compare
Member
Author
|
Hi @JoelSpeed and @sbueringer Thank you for the help all addressed. |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: 91384a821bc53e82b333bcbae4a51c6aca4e9d84 |
2 tasks
| // | ||
| // // +kubebuilder:webhook:...,namespaceSelector=`{"matchLabels":{"webhook-enabled":"true"}}` | ||
| // // +kubebuilder:webhook:...,namespaceSelector=`{"matchExpressions":[{"key":"environment","operator":"In","values":["dev","staging","prod"]}]}` | ||
| NamespaceSelector string `marker:"namespaceSelector,optional"` |
Member
There was a problem hiding this comment.
Can you instead of these two just add a patch marker that contains a strategic merge patch that will be applied over the rest of the webhook so any current and future field can be adjusted that way?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables filtering webhooks by namespace and object labels to solve the webhook bootstrap problem and support namespace-scoped operators. This markers will allow Kubebuilder abstracts the complexities.
Closes: #553 and #1338