-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🐛 Increase reconcile timeout for KCP & DockerMachine #13093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Increase reconcile timeout for KCP & DockerMachine #13093
Conversation
|
/cherry-pick release-1.12 |
|
@fabriziopandini: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test |
|
@fabriziopandini: The The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cluster-api-e2e-main-gke |
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 6e61c9b82dc5572803a8f3f7b844857e5a64ea6d |
|
/test pull-cluster-api-test-main |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
6e8635f to
878f649
Compare
878f649 to
5955c19
Compare
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 382dc13117768d39fa64b5b1fef87d8e60d9950c |
|
/cherry-pick release-1.12 |
|
@chrischdi: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold cancel |
|
@fabriziopandini: new pull request created: #13099 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
13006 also introduced a 1 minute timeout for all reconciler; it looks like this is too aggressive for the docker machine reconciler when it pre-load images or it runs kubeadm init/join. So I increased the timeout only for this controller
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area e2e-testing