Skip to content

🌱 e2e: do not expect Machines for MachinePools not supporting Machines #13071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Nov 28, 2025
Merged

🌱 e2e: do not expect Machines for MachinePools not supporting Machines #13071

k8s-ci-robot merged 1 commit into from
Nov 28, 2025

Conversation

@chrischdi
Copy link
Member

@chrischdi chrischdi commented Nov 28, 2025

What this PR does / why we need it:

When running tests e.g. for AKS and re-using the clusterctl upgrade test: there may not be any Machines to verify Readyness.

The test started to expect to always have Machines, which would not be the case for an use-case like AKS.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area e2e-testing

@k8s-ci-robot k8s-ci-robot added the area/e2e-testing Issues or PRs related to e2e testing label Nov 28, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 28, 2025
@chrischdi chrischdi changed the title 🌱 e2e: only verify Machines Ready if there are machines expected to exist [WIP] 🌱 e2e: only verify Machines Ready if there are machines expected to exist Nov 28, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 28, 2025
@chrischdi
Copy link
Member Author

chrischdi commented Nov 28, 2025

/hold

Let's wait for kubernetes-sigs/cluster-api-provider-azure#5979 to have green tests.
That is currently bumped to this PR rebased to release-1.11

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2025
@chrischdi
Copy link
Member Author

chrischdi commented Nov 28, 2025

Maybe requires a rebase after #13072 which is also part of this PR.

@chrischdi chrischdi force-pushed the pr-e2e-clusterctl-upgrade-verify-machines-ready-when-machines branch from fcad639 to 497ef23 Compare November 28, 2025 13:57
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2025
@chrischdi chrischdi changed the title [WIP] 🌱 e2e: only verify Machines Ready if there are machines expected to exist 🌱 e2e: only verify Machines Ready if there are machines expected to exist Nov 28, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2025
@chrischdi
Copy link
Member Author

chrischdi commented Nov 28, 2025

/hold cancel

looks good.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2025
@chrischdi
Copy link
Member Author

chrischdi commented Nov 28, 2025

/cherry-pick release-1.12

@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Nov 28, 2025

@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi
Copy link
Member Author

chrischdi commented Nov 28, 2025

/cherry-pick release-1.11

@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Nov 28, 2025

@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi chrischdi changed the title 🌱 e2e: only verify Machines Ready if there are machines expected to exist 🌱 e2e: do not expect Machines for MachinePools not supporting Machines Nov 28, 2025
fabriziopandini
fabriziopandini reviewed Nov 28, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 28, 2025

LGTM label has been added.

Git tree hash: 5230d112eb63fccd89eb21e419a768e90abaa137

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit dfb2a40 into kubernetes-sigs:main Nov 28, 2025
29 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 28, 2025
@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Nov 28, 2025

@chrischdi: new pull request created: #13077

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 28, 2025
Merged
@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Nov 28, 2025

@chrischdi: new pull request created: #13078

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@richardcase richardcase Awaiting requested review from richardcase

@sivchari sivchari Awaiting requested review from sivchari

Assignees

@fabriziopandini fabriziopandini

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.13

Development

Successfully merging this pull request may close these issues.

4 participants

@chrischdi @k8s-infra-cherrypick-robot @k8s-ci-robot @fabriziopandini