Skip to content

[release-1.11] 🐛 Fix a panic in conditions.Delete method if the sources condition list is empty #13054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 2 commits into from
Nov 26, 2025
Merged

[release-1.11] 🐛 Fix a panic in conditions.Delete method if the sources condition list is empty #13054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98a083e
fix a panic if the condition list is empty
Arakos Nov 25, 2025
3873165
backport panic fix to deprecated conditions.Delete method as well
Arakos Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion util/conditions/setter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,9 @@ func Delete(to Setter, conditionType string) {
}

conditions := to.GetConditions()
newConditions := make([]metav1.Condition, 0, len(conditions)-1)
// allocate same length array because the conditions length might be 0
// or the condition to be deleted might not be part of the list.
newConditions := make([]metav1.Condition, 0, len(conditions))
for _, condition := range conditions {
if condition.Type != conditionType {
newConditions = append(newConditions, condition)
Expand Down
4 changes: 3 additions & 1 deletion util/deprecated/v1beta1/conditions/v1beta2/setter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,9 @@ func Delete(to Setter, conditionType string) {
}

conditions := to.GetV1Beta2Conditions()
newConditions := make([]metav1.Condition, 0, len(conditions)-1)
// allocate same length array because the conditions length might be 0
// or the condition to be deleted might not be part of the list.
newConditions := make([]metav1.Condition, 0, len(conditions))
for _, condition := range conditions {
if condition.Type != conditionType {
newConditions = append(newConditions, condition)
Expand Down