-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 Migrate from Requeue to RequeueAfter in CABPK #12988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Migrate from Requeue to RequeueAfter in CABPK #12988
Conversation
Signed-off-by: sivchari <[email protected]>
| - staticcheck | ||
| text: 'SA1019: .*(res|result|i|j)\.Requeue is deprecated: Use `RequeueAfter` instead' | ||
| # TODO: Remove Requeue step by step | ||
| path: internal/controllers/(extensionconfig|machinepool)|util/util.go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change util/util.go to a local nolint in LowestNonZeroResult in the next PR (it's fine to combine it with a change to another controller)
We have to keep handling Requeue there until the field is removed by controller-runtime
(and I don't want to keep the exclude here so long because I'm not sure how long it will take to drop the field in CR)
|
/lgtm |
|
LGTM label has been added. Git tree hash: e85cfc7a72bbc05525d0c19eb5db96b0b53d23f3
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #