Skip to content

⚠️ Make the AfterClusterUpgrade hook blocking #12984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 2 commits into from
Nov 11, 2025
Merged

⚠️ Make the AfterClusterUpgrade hook blocking #12984

k8s-ci-robot merged 2 commits into from
Nov 11, 2025

Conversation

@fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Nov 10, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #12720

/area runtime-sdk

@k8s-ci-robot k8s-ci-robot added area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 10, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 10, 2025
@fabriziopandini
Copy link
Member Author

fabriziopandini commented Nov 10, 2025

/test

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 10, 2025

@fabriziopandini: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test pull-cluster-api-build-main

/test pull-cluster-api-e2e-blocking-main

/test pull-cluster-api-e2e-conformance-ci-latest-main

/test pull-cluster-api-e2e-conformance-main

/test pull-cluster-api-e2e-latestk8s-main

/test pull-cluster-api-e2e-main

/test pull-cluster-api-e2e-main-gke

/test pull-cluster-api-e2e-mink8s-main

/test pull-cluster-api-e2e-upgrade-1-34-1-35-main

/test pull-cluster-api-test-main

/test pull-cluster-api-test-mink8s-main

/test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-apidiff-main

pull-cluster-api-build-main

pull-cluster-api-e2e-blocking-main

pull-cluster-api-test-main

pull-cluster-api-verify-main

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fabriziopandini
Copy link
Member Author

fabriziopandini commented Nov 10, 2025

/test pull-cluster-api-e2e-main-gke

sbueringer
sbueringer reviewed Nov 11, 2025
View reviewed changes
@sbueringer sbueringer mentioned this pull request Nov 11, 2025
Open
36 tasks
@fabriziopandini
Make the AfterClusterUpgrade hook blocking
ff7df7b 
# Conflicts:
#	internal/webhooks/cluster.go
@fabriziopandini fabriziopandini force-pushed the make-AfterClusterUpgrade-hook-blocking branch from 42b2e9e to 430e631 Compare November 11, 2025 09:31
@fabriziopandini fabriziopandini added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 11, 2025
sbueringer
sbueringer reviewed Nov 11, 2025
View reviewed changes
@fabriziopandini fabriziopandini force-pushed the make-AfterClusterUpgrade-hook-blocking branch from 430e631 to b722b56 Compare November 11, 2025 09:56
@fabriziopandini fabriziopandini force-pushed the make-AfterClusterUpgrade-hook-blocking branch from b722b56 to f49e500 Compare November 11, 2025 10:01
@sbueringer
Copy link
Member

sbueringer commented Nov 11, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 11, 2025

LGTM label has been added.

Git tree hash: 5cbdf09d36aa3e84a4ea503f66f4497dab2554a0

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 11, 2025

@fabriziopandini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main f49e500 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member

sbueringer commented Nov 11, 2025

/test pull-cluster-api-e2e-main-gke

@k8s-ci-robot k8s-ci-robot merged commit 61e7368 into kubernetes-sigs:main Nov 11, 2025
18 of 19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Nov 11, 2025
@fabriziopandini fabriziopandini deleted the make-AfterClusterUpgrade-hook-blocking branch November 11, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbueringer sbueringer sbueringer left review comments

@elmiko elmiko Awaiting requested review from elmiko

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@sbueringer sbueringer

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

v1.12

Development

Successfully merging this pull request may close these issues.

3 participants

@fabriziopandini @k8s-ci-robot @sbueringer