🌱 Fix race condition on KCP initialized condition

[fabriziopandini]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #12870

/area provider/control-plane-kubeadm

[sbueringer]

/test pull-cluster-api-e2e-main-gke

[sbueringer]

Thx!

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 07fba791b0c572ea8a571745ffe06aeace844732

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fabriziopandini]

/cherry-pick release-1.11

[fabriziopandini]

/cherry-pick release-1.10

[k8s-infra-cherrypick-robot]

@fabriziopandini: new pull request created: #12986

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@fabriziopandini: #12980 failed to apply on top of branch "release-1.10":

Applying: Fix race condition on KCP initialized condition
Using index info to reconstruct a base tree...
M	controlplane/kubeadm/internal/controllers/status.go
M	controlplane/kubeadm/internal/controllers/status_test.go
Falling back to patching base and 3-way merge...
Auto-merging controlplane/kubeadm/internal/controllers/status_test.go
CONFLICT (content): Merge conflict in controlplane/kubeadm/internal/controllers/status_test.go
Auto-merging controlplane/kubeadm/internal/controllers/status.go
CONFLICT (content): Merge conflict in controlplane/kubeadm/internal/controllers/status.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Fix race condition on KCP initialized condition

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[fabriziopandini]

After looking into it, I have decided not backport to 1.10 for now.

The reason is that in 1.10 there is not yet a clean separation between regular code and conditions computation, and so the fix must be re-implemented from scratch

(feel free to pick it up if you have bandwidth)