Skip to content

🌱 Allow >1 minor version upgrades if generateUpgradePlan extension is defined #12979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Nov 11, 2025
Merged

🌱 Allow >1 minor version upgrades if generateUpgradePlan extension is defined #12979

k8s-ci-robot merged 1 commit into from
Nov 11, 2025

Conversation

@sbueringer
Copy link
Member

@sbueringer sbueringer commented Nov 10, 2025 •
edited
Loading

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #12720

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 10, 2025
@sbueringer sbueringer mentioned this pull request Nov 10, 2025
Open
36 tasks
@sbueringer sbueringer changed the title 🌱 Allow >1 minor version upgrades if generateUpgradePlan extension is 🌱 Allow >1 minor version upgrades if generateUpgradePlan extension is defined Nov 10, 2025
@sbueringer sbueringer added the area/cluster Issues or PRs related to clusters label Nov 10, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Nov 10, 2025
@sbueringer
Copy link
Member Author

sbueringer commented Nov 10, 2025

/test pull-cluster-api-e2e-main-gke

fabriziopandini
fabriziopandini reviewed Nov 10, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 10, 2025

LGTM label has been added.

Git tree hash: d6090caf1eba7fc846fc84f676c5f67fa9ff88c4

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2025
@sbueringer
Copy link
Member Author

sbueringer commented Nov 11, 2025

@fabriziopandini Looks like the autoscaler test is now failing pretty often. Not sure if even more since yesterday

@sbueringer
Copy link
Member Author

sbueringer commented Nov 11, 2025

/retest

@sbueringer
Copy link
Member Author

sbueringer commented Nov 11, 2025

I'll override for now as the tests are otherwise green. Let's continue on the issue

/override pull-cluster-api-e2e-main-gke

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 11, 2025

@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-main-gke

In response to this:

I'll override for now as the tests are otherwise green. Let's continue on the issue

/override pull-cluster-api-e2e-main-gke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 781ff73 into kubernetes-sigs:main Nov 11, 2025
32 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Nov 11, 2025
@sbueringer sbueringer deleted the pr-cluster-webhook-chained branch November 11, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@chrischdi chrischdi Awaiting requested review from chrischdi

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@fabriziopandini fabriziopandini

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster Issues or PRs related to clusters cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.12

Development

Successfully merging this pull request may close these issues.

3 participants

@sbueringer @k8s-ci-robot @fabriziopandini