Skip to content

Conversation

@jenniferplusplus
Copy link
Contributor

@jenniferplusplus jenniferplusplus commented Nov 3, 2025

What this PR does / why we need it:

This sets the mount options properly on /dev/fuse so that it can be mounted by podman. With this change, I've had success getting CAPD to create additional clusters under rootless podman.

I found that the quick start guide still doesn't work, because the the DockerMachineTemplates also need to mount the podman socket, and these checks need to be ignored on kubelet preflight:

ignorePreflightErrors:
- FileAvailable--etc-kubernetes-manifests-kube-apiserver.yaml
- FileAvailable--etc-kubernetes-manifests-kube-controller-manager.yaml
- FileAvailable--etc-kubernetes-manifests-kube-scheduler.yaml
- FileAvailable--etc-kubernetes-manifests-etcd.yaml

But, with that additional config, everything works as expected.

Fixes #12485

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 3, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @jenniferplusplus!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested a review from elmiko November 3, 2025 19:55
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 3, 2025
@k8s-ci-robot k8s-ci-robot requested a review from sivchari November 3, 2025 19:55
@k8s-ci-robot
Copy link
Contributor

Hi @jenniferplusplus. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stmcginnis
Copy link
Contributor

also need to mount the podman socket

I believe you need to install the Docker package so there is the docker socket available. Keep in mind that the "D" is CAPD is explicitly Docker.

Has this been tested with Docker as well? I don't think the fuse mount should be an issue, but that should be validated.

Also, looks like your bug reference is incorrect. It's currently pointed to a CLI output dependency update, so I don't think this has any impact on that.

@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 3, 2025
@jenniferplusplus
Copy link
Contributor Author

@stmcginnis yes, thank you, I mistyped the issue number. It should be #12485. I updated that.

I did also test this with docker, in an ubuntu VM.

I believe you need to install the Docker package so there is the docker socket available. Keep in mind that the "D" is CAPD is explicitly Docker.

This is also an issue with rootless docker. The generated templates mount the socket from the default root location, but with rootless it would usually be at /run/user/{id}/docker.sock. That, plus the preflight ignores were the only changes I had to make to the quick start templates.

@stmcginnis
Copy link
Contributor

Great, thanks for the extra details!

/lgtm
/area provider/infrastructure-docker

@k8s-ci-robot k8s-ci-robot added area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider and removed do-not-merge/needs-area PR is missing an area label labels Nov 4, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e1718c845f3b07c66d57442267b89634c52d746a

@jenniferplusplus
Copy link
Contributor Author

Is there anything else you need from me, for this to be mergeable?

@sbueringer
Copy link
Member

All good. Thank you!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit b3369d9 into kubernetes-sigs:main Nov 7, 2025
28 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CAPD tries to request device /dev/fuse:: on rootless podman which leads to invalid device mode error

4 participants