-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🐛 fix: CAPD on rootless podman #12941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix: CAPD on rootless podman #12941
Conversation
|
Welcome @jenniferplusplus! |
|
Hi @jenniferplusplus. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I believe you need to install the Docker package so there is the docker socket available. Keep in mind that the "D" is CAPD is explicitly Docker. Has this been tested with Docker as well? I don't think the fuse mount should be an issue, but that should be validated. Also, looks like your bug reference is incorrect. It's currently pointed to a CLI output dependency update, so I don't think this has any impact on that. |
|
/ok-to-test |
|
@stmcginnis yes, thank you, I mistyped the issue number. It should be #12485. I updated that. I did also test this with docker, in an ubuntu VM.
This is also an issue with rootless docker. The generated templates mount the socket from the default root location, but with rootless it would usually be at /run/user/{id}/docker.sock. That, plus the preflight ignores were the only changes I had to make to the quick start templates. |
|
Great, thanks for the extra details! /lgtm |
|
LGTM label has been added. Git tree hash: e1718c845f3b07c66d57442267b89634c52d746a
|
|
Is there anything else you need from me, for this to be mergeable? |
|
All good. Thank you! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This sets the mount options properly on
/dev/fuseso that it can be mounted by podman. With this change, I've had success getting CAPD to create additional clusters under rootless podman.I found that the quick start guide still doesn't work, because the the DockerMachineTemplates also need to mount the podman socket, and these checks need to be ignored on kubelet preflight:
But, with that additional config, everything works as expected.
Fixes #12485