Skip to content

[release-1.11] 🌱 kcp: enable websocket dialer with fallback to spdy #12931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
k8s-infra-cherrypick-robot wants to merge 1 commit into from
Closed

[release-1.11] 🌱 kcp: enable websocket dialer with fallback to spdy #12931

k8s-infra-cherrypick-robot wants to merge 1 commit into from

Conversation

@k8s-infra-cherrypick-robot
Copy link

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot commented Nov 3, 2025

This is an automated cherry-pick of #12902

/assign chrischdi

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 3, 2025
Merged
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Nov 3, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Nov 3, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 3, 2025
@chrischdi
Copy link
Member

chrischdi commented Nov 3, 2025

/test help

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 3, 2025

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cluster-api-build-release-1-11

/test pull-cluster-api-e2e-blocking-release-1-11

/test pull-cluster-api-e2e-conformance-ci-latest-release-1-11

/test pull-cluster-api-e2e-conformance-release-1-11

/test pull-cluster-api-e2e-mink8s-release-1-11

/test pull-cluster-api-e2e-release-1-11

/test pull-cluster-api-e2e-upgrade-1-33-1-34-release-1-11

/test pull-cluster-api-test-mink8s-release-1-11

/test pull-cluster-api-test-release-1-11

/test pull-cluster-api-verify-release-1-11

The following commands are available to trigger optional jobs:

/test pull-cluster-api-apidiff-release-1-11

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-apidiff-release-1-11

pull-cluster-api-build-release-1-11

pull-cluster-api-e2e-blocking-release-1-11

pull-cluster-api-test-release-1-11

pull-cluster-api-verify-release-1-11
Details

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi
Copy link
Member

chrischdi commented Nov 3, 2025

/area provider/control-plane-kubeadm

@k8s-ci-robot k8s-ci-robot added area/provider/control-plane-kubeadm Issues or PRs related to KCP and removed do-not-merge/needs-area PR is missing an area label labels Nov 3, 2025
@chrischdi
Copy link
Member

chrischdi commented Nov 3, 2025

/test pull-cluster-api-e2e-mink8s-release-1-11
/test pull-cluster-api-e2e-release-1-11

@chrischdi
Copy link
Member

chrischdi commented Nov 3, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 3, 2025

LGTM label has been added.

DetailsGit tree hash: 56122789f64b0654cec267423fabb42958d69401

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2025
@sbueringer
Copy link
Member

sbueringer commented Nov 3, 2025

/hold

Are we sure we want to backport this? We didn't have a lot of soak time and I think we shouldn't take a risk just so testgrid looks slightly better

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2025
@chrischdi
Copy link
Member

chrischdi commented Nov 3, 2025

I'm okay to skip this one :-)

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 3, 2025

@chrischdi: Closed this PR.

Details

In response to this:

I'm okay to skip this one :-)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@g-gaston g-gaston Awaiting requested review from g-gaston

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@chrischdi chrischdi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.11

Development

Successfully merging this pull request may close these issues.

4 participants

@k8s-infra-cherrypick-robot @chrischdi @k8s-ci-robot @sbueringer