Skip to content

✨ Implement GenerateUpgradePlan handler #12927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Nov 4, 2025
Merged

✨ Implement GenerateUpgradePlan handler #12927

k8s-ci-robot merged 1 commit into from
Nov 4, 2025

Conversation

@sivchari
Copy link
Member

@sivchari sivchari commented Nov 1, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #12720

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 1, 2025
fabriziopandini
fabriziopandini reviewed Nov 3, 2025
View reviewed changes
fabriziopandini
fabriziopandini reviewed Nov 3, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!
Only one nit from my side

@fabriziopandini
Copy link
Member

fabriziopandini commented Nov 3, 2025

/test

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 3, 2025

@fabriziopandini: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test pull-cluster-api-build-main

/test pull-cluster-api-e2e-blocking-main

/test pull-cluster-api-e2e-conformance-ci-latest-main

/test pull-cluster-api-e2e-conformance-main

/test pull-cluster-api-e2e-latestk8s-main

/test pull-cluster-api-e2e-main

/test pull-cluster-api-e2e-main-gke

/test pull-cluster-api-e2e-mink8s-main

/test pull-cluster-api-e2e-upgrade-1-34-1-35-main

/test pull-cluster-api-test-main

/test pull-cluster-api-test-mink8s-main

/test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-apidiff-main

pull-cluster-api-build-main

pull-cluster-api-e2e-blocking-main

pull-cluster-api-test-main

pull-cluster-api-verify-main

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fabriziopandini
Copy link
Member

fabriziopandini commented Nov 3, 2025

/test pull-cluster-api-e2e-latestk8s-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-34-1-35-main

@sbueringer sbueringer added the area/runtime-sdk Issues or PRs related to Runtime SDK label Nov 3, 2025
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/needs-area PR is missing an area label labels Nov 3, 2025
@sivchari sivchari force-pushed the implement-generate-upgrade-plan-handler branch from a581aac to 0a5fe8a Compare November 4, 2025 02:30
@sivchari sivchari force-pushed the implement-generate-upgrade-plan-handler branch from 0a5fe8a to 01ec43b Compare November 4, 2025 02:37
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2025
@sbueringer
Copy link
Member

sbueringer commented Nov 4, 2025

Thank you very much!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 4, 2025

LGTM label has been added.

Git tree hash: 44bbd61acf61136b0c8d787f26ab677c9d781f19

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6de38dd into kubernetes-sigs:main Nov 4, 2025
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Nov 4, 2025
@sbueringer sbueringer mentioned this pull request Nov 4, 2025
Open
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@elmiko elmiko Awaiting requested review from elmiko

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@sbueringer sbueringer

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.12

Development

Successfully merging this pull request may close these issues.

4 participants

@sivchari @fabriziopandini @k8s-ci-robot @sbueringer