-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 CAPD: recreate container if we re-enter reconciliation and it exists but is not running #12923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 CAPD: recreate container if we re-enter reconciliation and it exists but is not running #12923
Conversation
|
/test help |
|
@chrischdi: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…but is not running
8408f5e to
9bfdc0e
Compare
|
/test pull-cluster-api-e2e-main |
|
Nice finding, thank you very much!! /lgtm |
|
LGTM label has been added. DetailsGit tree hash: 407a6db695cb350e3b5470d1902c263a6adb5924 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.11 |
|
@chrischdi: new pull request created: #12933 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Fixes a race condition in CAPD, when CAPD gets interrupted (e.g. via loosing leader election) right after a container was created but container was not started yet.
Related to:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Area example:
/area provider/infrastructure-docker