🌱 Add defensive response status checking in runtime client #12898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for `response.GetStatus() != Success` instead of `response.GetStatus() == Failure` to handle unknown/invalid status values defensively. This ensures the runtime client properly validates that responses actually have a Success status rather than just checking they're not Failure. Signed-off-by: Furkat Gofurov <[email protected]>
k8s-ci-robot
added
area/runtime-sdk
Member
|
Thank you very much!! /lgtm /test pull-cluster-api-e2e-main |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: e97f503b47822dddd1ff55c9a59c0d5f9f844ace
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
80 tasks
Member
Author
|
/test pull-cluster-api-test-main |
github-project-automation
bot
moved this from PR to be reviewed
to Done
in CAPI / Turtles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds defensive response status checking to the runtime client to validate that extension handler responses properly have a
Successstatus, rather than just checking they don't have aFailurestatus.Currently, the runtime client checks if
response.GetStatus() == ResponseStatusFailure, which means any other value (including empty string, nil, or invalid values) would be treated as success.Example Error Messages
Before: Unknown status would be silently accepted as success
After:
"failed to call extension: ExtensionHandler X got failure response ...""failed to call extension: ExtensionHandler X got unknown response status \"foo\""/area runtime-sdk
Part of #12291