Skip to content

Conversation

@arshadd-b
Copy link
Contributor

What this PR does / why we need it:
Bumps cert-manager to v1.19.0
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Oct 8, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 8, 2025
@k8s-ci-robot
Copy link
Contributor

@arshadd-b: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 33e0f68 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main

@sbueringer sbueringer added the area/clusterctl Issues or PRs related to clusterctl label Oct 8, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Oct 8, 2025
@sbueringer
Copy link
Member

Looks like some of our links in the book broke. But let's fix this in a separate PR

@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 07ac567a921d6d7453f83623adf404f8ecba4b6b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2025
@sbueringer
Copy link
Member

@arshadd-b Tests green. I'll merge.

Let's fix the markdown issue(s) independently

@richardcase Looks like https://capi-samples.github.io/kubecon-na-2022-tutorial/ is offline now (from: "So You Want To Develop a Cluster API Provider? - October 2022").
Should we drop the link or is there an alternative link we should use?

@sbueringer sbueringer merged commit 82f5743 into kubernetes-sigs:main Oct 8, 2025
20 of 24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Oct 8, 2025
@sbueringer
Copy link
Member

/cherry-pick release-1.11

@sbueringer
Copy link
Member

/cherry-pick release-1.10

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #12832

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@sbueringer: #12828 failed to apply on top of branch "release-1.10":

Applying: update cert-manager to v1.19.0
Using index info to reconstruct a base tree...
M	cmd/clusterctl/client/config/cert_manager_client.go
M	docs/book/src/clusterctl/commands/init.md
M	docs/book/src/developer/getting-started.md
M	scripts/ci-e2e-lib.sh
M	test/e2e/config/docker.yaml
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/config/docker.yaml
CONFLICT (content): Merge conflict in test/e2e/config/docker.yaml
Auto-merging scripts/ci-e2e-lib.sh
CONFLICT (content): Merge conflict in scripts/ci-e2e-lib.sh
Auto-merging docs/book/src/developer/getting-started.md
CONFLICT (content): Merge conflict in docs/book/src/developer/getting-started.md
Auto-merging docs/book/src/clusterctl/commands/init.md
CONFLICT (content): Merge conflict in docs/book/src/clusterctl/commands/init.md
Auto-merging cmd/clusterctl/client/config/cert_manager_client.go
CONFLICT (content): Merge conflict in cmd/clusterctl/client/config/cert_manager_client.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 update cert-manager to v1.19.0

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member

@arshadd-b Can you please open the same PR against release-1.10? Thank you!

@sbueringer
Copy link
Member

@arshadd-b Tests green. I'll merge.

Let's fix the markdown issue(s) independently

@richardcase Looks like capi-samples.github.io/kubecon-na-2022-tutorial is offline now (from: "So You Want To Develop a Cluster API Provider? - October 2022"). Should we drop the link or is there an alternative link we should use?

PR: #12835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants