🌱 Add rollout planner #12804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

k8s-ci-robot merged 5 commits into kubernetes-sigs:main from fabriziopandini:add-rollout-planner

Oct 1, 2025

Member

fabriziopandini commented Sep 26, 2025

What this PR does / why we need it:
This PR adds the seed version of the rolloutPlanner to the MachineDeployment controller.

Please note:

This version of the rollout planner is minimal, some pieces are still missing, see TODOs
Even if still incomplete, this version already allow to increase coverage on the rollout process, by testing rollout sequences
Notably, this new tests surfaced two race conditions in the scale down oldMS logic, see TODOs
I will follow up for TODOs and the work to support in-place updates will start after the above issues are fixed

(we also agreed to proceed with small incremental changes given the complexity of this part of the codebase)

Which issue(s) this PR fixes :
Part of #12291

/area machinedeployment


          Add rollout planner

ba93b67

k8s-ci-robot added area/machinedeployment cncf-cla: yes labels

k8s-ci-robot requested review from chrischdi and vincepri

September 26, 2025 13:07

k8s-ci-robot added the size/XXL label

Member Author

fabriziopandini commented Sep 26, 2025

/test ?

Contributor

k8s-ci-robot commented Sep 26, 2025

@fabriziopandini: The following commands are available to trigger required jobs:

/test pull-cluster-api-build-main

/test pull-cluster-api-e2e-blocking-main

/test pull-cluster-api-e2e-conformance-ci-latest-main

/test pull-cluster-api-e2e-conformance-main

/test pull-cluster-api-e2e-latestk8s-main

/test pull-cluster-api-e2e-main

/test pull-cluster-api-e2e-mink8s-main

/test pull-cluster-api-e2e-upgrade-1-34-1-35-main

/test pull-cluster-api-test-main

/test pull-cluster-api-test-mink8s-main

/test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-apidiff-main

pull-cluster-api-build-main

pull-cluster-api-e2e-blocking-main

pull-cluster-api-test-main

pull-cluster-api-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

fabriziopandini mentioned this pull request

Tracking issue for In-place Updates implementation #12291

Open

80 tasks

Member Author

fabriziopandini commented Sep 26, 2025

/test pull-cluster-api-e2e-main

Member Author

fabriziopandini commented Sep 26, 2025

/test pull-cluster-api-test-main

Member

sbueringer commented Sep 26, 2025

/test pull-cluster-api-e2e-main


          Minor improvements

4bf2661

fabriziopandini added the tide/merge-method-squash label

Member Author

fabriziopandini commented Sep 29, 2025

/test pull-cluster-api-e2e-main

1 similar comment

Member

sbueringer commented Sep 30, 2025

/test pull-cluster-api-e2e-main

sbueringer reviewed

View reviewed changes

internal/controllers/machinedeployment/machinedeployment_rolling.go Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rolling.go Outdated Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rolling.go Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rolling.go Outdated Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rolling.go Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rolling.go Outdated Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rolling.go Outdated Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_ondelete.go Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_ondelete.go Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_ondelete.go Outdated Show resolved Hide resolved


          Address feedback

9988c42

sbueringer reviewed

View reviewed changes

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Outdated Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Outdated Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Outdated Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Outdated Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Outdated Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Outdated Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Show resolved Hide resolved

sbueringer reviewed

View reviewed changes

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Outdated Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Outdated Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Outdated Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Outdated Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Outdated Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Outdated Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Outdated Show resolved Hide resolved


          More feedback

4565d00

Member Author

fabriziopandini commented Sep 30, 2025

/test pull-cluster-api-e2e-main

sbueringer reviewed

View reviewed changes

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Outdated Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Outdated Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Outdated Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Outdated Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Show resolved Hide resolved

internal/controllers/machinedeployment/machinedeployment_rollout_sequence_test.go Show resolved Hide resolved

sbueringer reviewed

View reviewed changes

...eployment/testdata/regular rollout, 3 replicas, maxsurge 0, maxunavailable 1.test.log.golden Show resolved Hide resolved


          More feedback

fabriziopandini force-pushed the add-rollout-planner branch from ded2462 to 4659076 Compare

October 1, 2025 08:45

Member

sbueringer commented Oct 1, 2025

/lgtm
/approve

k8s-ci-robot assigned sbueringer

k8s-ci-robot added the lgtm label

Contributor

k8s-ci-robot commented Oct 1, 2025

LGTM label has been added.

Git tree hash: 92aa32d27619b348f811d6eefb6be78e1958f504

Contributor

k8s-ci-robot commented Oct 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the approved label

k8s-ci-robot merged commit a0bb17c into kubernetes-sigs:main

18 checks passed

k8s-ci-robot added this to the v1.12 milestone

fabriziopandini mentioned this pull request

🐛 Fix race conditions ScaleDownOldMS #12812

Merged

fabriziopandini deleted the add-rollout-planner branch

November 11, 2025 16:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/machinedeployment cncf-cla: yes lgtm size/XXL tide/merge-method-squash